fix: eslint suggestions

Author: baslu93

.gitignore

@@ -44,3 +44,4 @@ node_modules
 .idea
 
 oclif.manifest.json
+oclif.lock

package.json

@@ -5,8 +5,11 @@
   "devDependencies": {
     "@salesforce/cli-plugins-testkit": "^5.0.6",
     "@salesforce/dev-scripts": "^7.1.1",
+    "eslint-plugin-sf-plugin": "^1.16.15",
     "mocha": "^10.2.0",
     "nyc": "^15.1.0",
+    "oclif": "^4.0.4",
+    "shx": "^0.3.4",
     "ts-node": "^10.9.1",
     "wireit": "^0.14.1"
   },

src/metadataHelper.ts

@@ -1,4 +1,4 @@
-import * as fs from 'fs';
+import * as fs from 'node:fs';
 import { ComponentSetBuilder } from '@salesforce/source-deploy-retrieve';
 import { SfProject } from '@salesforce/core';
 
@@ -9,6 +9,10 @@ export class MetadataHelper {
     this.apiversion = apiversion;
   }
 
+  public static readFileUtf8(path: string): string {
+    return fs.readFileSync(path, 'utf8');
+  }
+
   public async getElements<T>(entries: string[]): Promise<T[]> {
     const project = await SfProject.resolve();
     const paths = project.getUniquePackageDirectories().map((pDir) => pDir.fullPath);
@@ -23,13 +27,9 @@ export class MetadataHelper {
     const result = new Array<T>();
     const sourceComponents = componentSet.getSourceComponents().toArray();
     for (const sourceComponent of sourceComponents) {
-      const recipeString = this.readFileUtf8(sourceComponent?.content as string);
+      const recipeString = MetadataHelper.readFileUtf8(sourceComponent?.content as string);
       result.push(JSON.parse(recipeString) as T);
     }
     return result;
   }
-
-  public readFileUtf8(path: string) {
-    return fs.readFileSync(path, 'utf8');
-  }
 }

src/modules/upsert.d.ts

@@ -60,7 +60,7 @@ export type RecipeDefinitionNodes = {
 
 export type RecipeDefinitionNode = {
   action: string;
-  parameters: LoadDefinitionNodeParam | unknown;
+  parameters: unknown;
   sources: string[];
 };
 
@@ -84,4 +84,4 @@ export type GetDataConnectors = {
 export type ChangedAndMissingFields = {
   changedFields: string[];
   missingFields: string[];
-}
+};

test/commands/analytics/connected-objects/upsert.nut.ts

@@ -1,4 +1,4 @@
-import * as path from 'path';
+import * as path from 'node:path';
 import { expect } from 'chai';
 import { TestSession, execCmd } from '@salesforce/cli-plugins-testkit';
 import { Messages } from '@salesforce/core';
@@ -47,36 +47,36 @@ describe('analytics connected-objects upsert NUTs', () => {
     const output = execCmd<ConnectedObjectUpsertResult[]>(command, { ensureExitCode: 0, cli: 'sf' }).jsonOutput;
     expect(output).to.deep.equal({
       status: 0,
-      result: [{
-        connectorName: 'SFDC_LOCAL',
-        objectName: 'User',
-        isNew: false,
-        fields: [
-          'LastName',
-          'FirstName',
-          'CompanyName',
-          'Email',
-          'Phone',
-          'MobilePhone',
-          'UserRoleId',
-          'ProfileId',
-          'LanguageLocaleKey',
-          'LastLoginDate',
-          'CreatedDate',
-          'LastModifiedDate',
-        ],
-        fieldsCount: 12,
-      },
-      {
-        connectorName: 'SFDC_LOCAL',
-        objectName: 'Profile',
-        isNew: true,
-        fields: ['Id', 'Name'],
-        fieldsCount: 2,
-      }],
-      warnings: [
-        messages.getMessage('fields.not.found', [ 'User', 'SFDC_LOCAL' , 'Extra__c'])
-      ]
+      result: [
+        {
+          connectorName: 'SFDC_LOCAL',
+          objectName: 'User',
+          isNew: false,
+          fields: [
+            'LastName',
+            'FirstName',
+            'CompanyName',
+            'Email',
+            'Phone',
+            'MobilePhone',
+            'UserRoleId',
+            'ProfileId',
+            'LanguageLocaleKey',
+            'LastLoginDate',
+            'CreatedDate',
+            'LastModifiedDate',
+          ],
+          fieldsCount: 12,
+        },
+        {
+          connectorName: 'SFDC_LOCAL',
+          objectName: 'Profile',
+          isNew: true,
+          fields: ['Id', 'Name'],
+          fieldsCount: 2,
+        },
+      ],
+      warnings: [messages.getMessage('fields.not.found', ['User', 'SFDC_LOCAL', 'Extra__c'])],
     });
   });
 });

test/commands/analytics/connected-objects/upsert.test.ts

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-import { resolve } from 'path';
+import { resolve } from 'node:path';
 import { expect } from 'chai';
 import { TestContext, MockTestOrgData } from '@salesforce/core/lib/testSetup';
 import { ensureJsonMap, AnyJson } from '@salesforce/ts-types';
@@ -128,5 +128,5 @@ function stubMethodsInMetadataHelper(testContext: TestContext, result: unknown):
   testContext.SANDBOX.stub(ComponentSet.prototype, 'getSourceComponents').returns(
     new LazyCollection([{ content: 'my/path' } as SourceComponent])
   );
-  testContext.SANDBOX.stub(MetadataHelper.prototype, 'readFileUtf8').returns(JSON.stringify(result));
+  testContext.SANDBOX.stub(MetadataHelper, 'readFileUtf8').returns(JSON.stringify(result));
 }