Skip to content

Commit 4e1fd5d

Browse files
ggtrdggtrd
authored andcommitted
Multiple improvements
1 parent 6f5d9c6 commit 4e1fd5d

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

bashpack.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ export URL # Export URL to be usable on tests
261261
# This permit to test the CLI from the scripts directly and avoid having to release it at each test.
262262
if [[ $0 = "./$NAME_LOWERCASE.sh" ]] && [[ -d "commands" ]]; then
263263
echo "Warning: you are currently using '$0' which is located in $(pwd). This might be a cloned repository of $NAME."
264+
echo ""
264265
COMMAND_UPDATE="commands/update.sh"
265266
COMMAND_MAN="commands/man.sh"
266267
COMMAND_VERIFY_INTALLATION="commands/tests.sh"
@@ -433,6 +434,7 @@ check_repository_reachability() {
433434
echo "Error: HTTP status code $http_code. Repository is not reachable."
434435
fi
435436
}
437+
export -f check_repository_reachability
436438

437439

438440

@@ -653,7 +655,7 @@ update_cli() {
653655
echo $error_already_installed
654656
else
655657

656-
# download_cli "$URL/tarball" $archive_tmp $archive_dir_tmp
658+
download_cli "$URL/tarball" $archive_tmp $archive_dir_tmp
657659

658660
# To avoid broken installations, before deleting anything, testing if downloaded archive is a working tarball.
659661
# (archive is deleted in create_cli, which is called after in the process)
@@ -695,6 +697,7 @@ install_cli() {
695697

696698

697699

700+
698701
# The options (except --help) must be called with root
699702
case "$1" in
700703
-i|--self-install) install_cli ;; # Critical option, see the comments at function declaration for more info

0 commit comments

Comments
 (0)