Merge pull request #259 from DannyBen/update/validator-default-command

Update validator to alert when a default command has no args

Author: DannyBen

lib/bashly/config_validator.rb

@@ -142,6 +142,10 @@ def assert_command(key, value)
       assert_uniq "#{key}.flags", value['flags'], 'short'
       assert_uniq "#{key}.args", value['args'], 'name'
 
+      if value['default']
+        assert value['args'], "#{key}.default makes no sense without args"
+      end
+
       if value['catch_all'] and value['args']
         repeatable_arg = value['args'].select { |a| a['repeatable'] }.first&.dig 'name'
         refute repeatable_arg, "#{key}.catch_all makes no sense with repeatable arg (#{repeatable_arg})"

spec/approvals/validations/commands_default_without_args

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.commands[0].default makes no sense without args>

spec/fixtures/script/validations.yml

@@ -8,16 +8,16 @@
   name: invalid
   help: last nested arg does not have a name
   commands:
-    - name: level1
-      commands:
-        - name: level2a
-          args:
-            - name: ok
-            - name: alright
-        - name: level2b
-          args:          
-            - name: ok
-            - help: there is no name
+  - name: level1
+    commands:
+    - name: level2a
+      args:
+      - name: ok
+      - name: alright
+    - name: level2b
+      args:          
+      - name: ok
+      - help: there is no name
 
 :command_catch_all_type:
   name: invalid
@@ -102,6 +102,13 @@
   flags:
   - long: --force
 
+:commands_default_without_args:
+  name: invalid
+  help: default command requires args
+  commands:
+  - name: sub
+    default: true
+
 :env_var:
   name: invalid
   help: env_var.required should be a boolean
@@ -201,6 +208,8 @@
   name: invalid
   help: root cannot have default
   default: true
+  args:
+  - name: ok
 
 :root_expose:
   name: invalid