Fix all warnings and cleanup FakerLocaleInstance

Author: baileydauterman

src/Faker.NET.Data/ResourceRetriever.cs

@@ -10,7 +10,7 @@ public ResourceRetriever()
             _availableResources = Assembly.GetExecutingAssembly().GetManifestResourceNames() ?? Array.Empty<string>();
         }
 
-        public T? Get<T>(string locale, string module, string name)
+        public T Get<T>(string locale, string module, string name)
         {
             name = $"Faker.NET.Data.{locale.ToUpper()}.{module}.{name}.json";
             if (_availableResources.Contains(name))
@@ -20,18 +20,18 @@ public ResourceRetriever()
                 {
                     PropertyNameCaseInsensitive = true,
                 });
-                return deserialized;
+                return deserialized ?? Activator.CreateInstance<T>();
             }
 
-            return default;
+            return Activator.CreateInstance<T>();
         }
 
         public IReadOnlyCollection<T> GetAsArray<T>(string locale, string module, string name)
         {
             return Get<List<T>>(locale, module, name) ?? new List<T>();
         }
 
-        public Dictionary<T, U> Get<T, U>(string locale, string module, string name)
+        public Dictionary<T, U> Get<T, U>(string locale, string module, string name) where T : notnull
         {
             return Get<Dictionary<T, U>>(locale, module, name) ?? new Dictionary<T, U>();
         }

src/Faker.NET/Common/Airline/BaseAirlineInformation.cs

@@ -5,10 +5,10 @@ namespace Faker.NET.Common.Airline;
 public class BaseAirlineInformation
 {
     [JsonPropertyName("name")]
-    public string Name { get; set; }
+    public string Name { get; set; } = string.Empty;
 
     [JsonPropertyName("iataCode")]
-    public string IataCode { get; set; }
+    public string IataCode { get; set; } = string.Empty;
 
     public override string ToString()
     {

src/Faker.NET/Common/MustacheHandler.cs

@@ -13,7 +13,7 @@ public string Replace(string template, Dictionary<string, Func<string>> replacem
             var indexStarts = Task.Run(() => FindAll(template, "{{").ToArray());
             var indexEnds = Task.Run(() => FindAll(template, "}}").ToArray());
 
-            _builder = new StringBuilder();
+            var builder = new StringBuilder();
             Task.WaitAll(indexStarts, indexEnds);
 
             int previousEnd = 0;
@@ -22,17 +22,17 @@ public string Replace(string template, Dictionary<string, Func<string>> replacem
             {
                 if (previousEnd < start)
                 {
-                    _builder.Append(template.AsSpan(previousEnd, start - previousEnd));
+                    builder.Append(template.AsSpan(previousEnd, start - previousEnd));
                 }
 
                 var startToEnd = start + 2;
                 var word = template.Substring(startToEnd, end - startToEnd);
-                _builder.Append(GetWordReplacement(word, replacements));
+                builder.Append(GetWordReplacement(word, replacements));
 
                 previousEnd = end + 2;
             }
 
-            return _builder.ToString();
+            return builder.ToString();
         }
 
         private string GetWordReplacement(string word, Dictionary<string, Func<string>> replacement)
@@ -62,8 +62,6 @@ private IEnumerable<int> FindAll(string template, string characters)
             yield break;
         }
 
-        private StringBuilder _builder;
-
         // private readonly Regex _mustaches = new Regex("^{{(?<word>[\\w\\.]+)(?:\\[(?<index>\\d+)\\])?");
         private readonly Regex _index = new Regex("\\[(?<idx>\\d+)\\]");
         private readonly Dictionary<string, Func<string>> _commonReplacements = new Dictionary<string, Func<string>>

src/Faker.NET/Common/WeightedArray.cs

@@ -2,7 +2,7 @@
 
 namespace Faker.NET.Common;
 
-public class WeightedList<T>
+public class WeightedList<T> where T : notnull
 {
     public WeightedList()
     {
@@ -34,6 +34,7 @@ public T GetValue()
         {
             return _values[0];
         }
+
         var value = Faker.Randomizer.Next(_totalWeight);
 
         for (int i = 0; i < _weights.Count; i++)
@@ -44,7 +45,7 @@ public T GetValue()
             }
         }
 
-        return default;
+        return Activator.CreateInstance<T>();
     }
 
     private List<T> _values = new List<T>();

src/Faker.NET/Implementations/Definitions/BaseFakerCommerceProductNameDefinition.cs

@@ -6,12 +6,12 @@ namespace Faker.NET.Implementations.Definitions
     internal class BaseFakerCommerceProductNameDefinition : IFakerCommerceProductNameDefinition
     {
         [JsonPropertyName("adjective")]
-        public string[] Adjective { get; set; }
+        public string[] Adjective { get; set; } = Array.Empty<string>();
 
         [JsonPropertyName("material")]
-        public string[] Material { get; set; }
+        public string[] Material { get; set; } = Array.Empty<string>();
 
         [JsonPropertyName("product")]
-        public string[] Product { get; set; }
+        public string[] Product { get; set; } = Array.Empty<string>();
     }
 }

src/Faker.NET/Implementations/Modules/FakerLorem.cs

@@ -1,11 +1,11 @@
 using System.Text;
 using Faker.NET.Extensions;
-using Faker.NET.Interfaces.Definitions;
+using Faker.NET.Implementations.Definitions;
 using Faker.NET.Interfaces.Modules;
 
 namespace Faker.NET.Implementations.Modules;
 
-internal class FakerLorem<T> : FakerDefinitionHandler<T>, IFakerLorem where T : IFakerLoremDefinition
+internal class FakerLorem : FakerDefinitionHandler<BaseFakerLoremDefinition>, IFakerLorem
 {
     public string Words(int min, int max) => Data.Words.CreateRandomString(min, max);
 

src/Faker.NET/Locales/DE/DELocale.cs

@@ -1,5 +1,4 @@
 using System.Globalization;
-using Faker.NET.Implementations.Definitions;
 using Faker.NET.Implementations.Modules;
 using Faker.NET.Locales.DE.Data;
 
@@ -11,7 +10,7 @@ public DELocale()
         {
             Person = new FakerPerson<DeFakerPersonData>();
             PhoneNumber = new FakerPhone<DePhoneNumberData>();
-            Lorem = new FakerLorem<BaseFakerLoremDefinition>();
+            Lorem = new FakerLorem();
             Location = new FakerLocation<DeLocationData>();
             Culture = CultureInfo.GetCultureInfo("de");
         }

src/Faker.NET/Locales/EN/ENLocale.cs

@@ -18,6 +18,6 @@ public ENLocale()
         Date = new FakerDate();
         Internet = new FakerInternet<BaseFakerInternetDefinition>();
         PhoneNumber = new FakerPhone<EnFakerPhoneData>();
-        Lorem = new FakerLorem<BaseFakerLoremDefinition>();
+        Lorem = new FakerLorem();
     }
 }

src/Faker.NET/Locales/ES/ESLocale.cs

@@ -1,5 +1,4 @@
 using System.Globalization;
-using Faker.NET.Implementations.Definitions;
 using Faker.NET.Implementations.Modules;
 
 namespace Faker.NET.Locales.ES
@@ -8,8 +7,8 @@ internal class ESLocale : FakerLocaleInstance
     {
         public ESLocale()
         {
-            Lorem = new FakerLorem<BaseFakerLoremDefinition>();
             Culture = CultureInfo.GetCultureInfo("es");
+            Lorem = new FakerLorem();
         }
     }
 }

src/Faker.NET/Locales/RU/RULocale.cs

@@ -1,5 +1,4 @@
 using System.Globalization;
-using Faker.NET.Implementations.Definitions;
 using Faker.NET.Implementations.Modules;
 using Faker.NET.Locales.RU.Data;
 
@@ -9,10 +8,11 @@ internal class RULocale : FakerLocaleInstance
     {
         public RULocale()
         {
+            Culture = CultureInfo.GetCultureInfo("ru");
+
             Person = new FakerPerson<RuFakerPersonData>();
-            Lorem = new FakerLorem<BaseFakerLoremDefinition>();
+            Lorem = new FakerLorem();
             PhoneNumber = new FakerPhone<RuPhoneNumberData>();
-            Culture = CultureInfo.GetCultureInfo("ru");
         }
     }
 }