Adding support for "ssl" and "singleTransaction" (#29)

* Adding support for "ssl" and "singleTransaction"

* Fixed tests

Author: Nyholm

DependencyInjection/Configuration.php

@@ -62,13 +62,16 @@ public function getConfigTreeBuilder()
                     ->validate()
                         ->ifTrue(function ($databases) {
                             $valid = true;
-                            foreach ($databases as $database) {
-                                $valid = $valid && (empty($database['ignoreTables']) || $database['type'] === 'mysql');
+                            foreach ($databases as $d) {
+                                if ($d['type'] !== 'mysql') {
+                                    // If not "mysql" we have to make sure these parameter are set to default
+                                    $valid = $valid && empty($d['ignoreTables']) && empty($d['ssl']) && empty($d['singleTransaction']);
+                                }
                             }
 
                             return !$valid;
                         })
-                        ->thenInvalid('Key "ignoreTables" is only valid on MySQL databases.')
+                        ->thenInvalid('Keys "ignoreTables", "ssl" and "singleTransaction" are only valid on MySQL databases.')
                     ->end()
                     ->validate()
                         ->always(function ($databases) {
@@ -88,6 +91,8 @@ public function getConfigTreeBuilder()
                             ->scalarNode('user')->end()
                             ->scalarNode('pass')->end()
                             ->scalarNode('database')->end()
+                            ->booleanNode('singleTransaction')->end()
+                            ->booleanNode('ssl')->end()
                             ->arrayNode('ignoreTables')
                                 ->scalarPrototype()->end()
                             ->end()

Tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -33,7 +33,7 @@ public function testIgnoreTablesGeneratesErrorWhenNotUsingMySQL()
                     ],
                 ]
             ),
-            'Key "ignoreTables" is only valid on MySQL databases.'
+            'Keys "ignoreTables", "ssl" and "singleTransaction" are only valid on MySQL databases.'
         );
     }
 
@@ -53,4 +53,85 @@ public function testIgnoreTablesDoesNothingWhenOmitted()
             )
         );
     }
+
+    public function testSslGeneratesErrorWhenNotUsingMySQL()
+    {
+        $this->assertConfigurationIsInvalid(array(
+                [
+                    'database'=>[
+                        'dev'=>[
+                            'type' => 'foo',
+                            'ssl' => true,
+                        ],
+                        'prod'=>[
+                            'type' => 'mysql',
+                        ],
+                    ],
+                ]
+            ),
+            'Keys "ignoreTables", "ssl" and "singleTransaction" are only valid on MySQL databases.'
+        );
+    }
+
+    public function testSslOnValid()
+    {
+        $this->assertConfigurationIsValid(array(
+                [
+                    'database'=>[
+                        'dev'=>[
+                            'type' => 'foo',
+                        ],
+                        'test'=>[
+                            'type' => 'bar',
+                            'ssl' => false,
+                        ],
+                        'prod'=>[
+                            'type' => 'mysql',
+                            'ssl' => true,
+                        ],
+                    ],
+                ]
+            )
+        );
+    }
+
+    public function testSingleTransactionGeneratesErrorWhenNotUsingMySQL()
+    {
+        $this->assertConfigurationIsInvalid(array(
+                [
+                    'database'=>[
+                        'dev'=>[
+                            'type' => 'foo',
+                            'singleTransaction' => true,
+                        ],
+                        'prod'=>[
+                            'type' => 'mysql',
+                        ],
+                    ],
+                ]
+            ),
+            'Keys "ignoreTables", "ssl" and "singleTransaction" are only valid on MySQL databases.'
+        );
+    }
+
+    public function testSingleTransactionOnValid()
+    {
+        $this->assertConfigurationIsValid(array(
+                [
+                    'database'=>[
+                        'dev'=>[
+                            'type' => 'foo',
+                        ],
+                        'test'=>[
+                            'type' => 'bar',
+                            'singleTransaction' => false,
+                        ],
+                        'prod'=>[
+                            'type' => 'mysql',
+                        ],
+                    ],
+                ]
+            )
+        );
+    }
 }