Make sure we can use the bundle with no config. (#37)

This will fix #34

Author: Nyholm

DependencyInjection/BMBackupManagerExtension.php

@@ -27,6 +27,8 @@ public function load(array $configs, ContainerBuilder $container)
 
         $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.yml');
+        $config['storage'] = isset($config['storage']) ? $config['storage'] : [];
+        $config['database'] = isset($config['database']) ? $config['database'] : [];
         $this->validateStorage($config['storage']);
 
         $managerIdMap = [

DependencyInjection/Configuration.php

@@ -58,7 +58,7 @@ public function getConfigTreeBuilder()
 
                 ->end() // End storage
 
-                ->arrayNode('database')->isRequired()
+                ->arrayNode('database')
                     ->validate()
                         ->ifTrue(function ($databases) {
                             $valid = true;

Tests/Functional/BundleInitializationTest.php

@@ -5,6 +5,7 @@
 use BackupManager\Manager;
 use BM\BackupManagerBundle\BMBackupManagerBundle;
 use Nyholm\BundleTest\BaseBundleTestCase;
+use Nyholm\BundleTest\CompilerPass\PublicServicePass;
 
 class BundleInitializationTest extends BaseBundleTestCase
 {
@@ -13,14 +14,20 @@ protected function getBundleClass()
         return BMBackupManagerBundle::class;
     }
 
+    protected function setUp()
+    {
+        $this->addCompilerPass(new PublicServicePass('|backup_manager.*|'));
+        $this->addCompilerPass(new PublicServicePass('|backup_manager|'));
+    }
+
+
     public function testInitBundle()
     {
         // Create a new Kernel
         $kernel = $this->createKernel();
 
         // Add some configuration
         $kernel->addConfigFile(__DIR__.'/config/minimal.yml');
-        $kernel->addConfigFile(__DIR__.'/config/public_services.yml');
 
         // Boot the kernel.
         $this->bootKernel();
@@ -29,8 +36,22 @@ public function testInitBundle()
         $container = $this->getContainer();
 
         // Test if you services exists
-        $this->assertTrue($container->has('test.backup_manager'));
-        $service = $container->get('test.backup_manager');
+        $this->assertTrue($container->has('backup_manager'));
+        $service = $container->get('backup_manager');
+        $this->assertInstanceOf(Manager::class, $service);
+    }
+
+    public function testNoConfig()
+    {
+        // Boot the kernel.
+        $this->bootKernel();
+
+        // Get the container
+        $container = $this->getContainer();
+
+        // Test if you services exists
+        $this->assertTrue($container->has('backup_manager'));
+        $service = $container->get('backup_manager');
         $this->assertInstanceOf(Manager::class, $service);
     }
 
@@ -43,12 +64,11 @@ public function testNoDependencies()
 
         // Add some configuration
         $kernel->addConfigFile(__DIR__.'/config/rackspace.yml');
-        $kernel->addConfigFile(__DIR__.'/config/public_services.yml');
 
         // Boot the kernel.
         $this->bootKernel();
 
         // Get the container
         $container = $this->getContainer();
     }
-}
+}

Tests/Functional/config/public_services.yml

@@ -24,7 +24,7 @@
     "require-dev": {
         "matthiasnoback/symfony-dependency-injection-test": "^1.2 || ^2.3",
         "matthiasnoback/symfony-config-test": "^2.2 || ^3.1",
-        "nyholm/symfony-bundle-test": "^1.2",
+        "nyholm/symfony-bundle-test": "^1.3.1",
         "symfony/phpunit-bridge": "^3.4 || ^4.0"
     },
     "suggest": {