Merge pull request #10 from backsofangels/refactoring

Removed unnecessary dependences and fixed strings.xml

Author: Salvatore Penitente

app/build.gradle

@@ -37,9 +37,6 @@ dependencies {
     implementation 'com.android.support:recyclerview-v7:28.0.0'
     implementation 'com.android.support:cardview-v7:28.0.0'
     implementation 'com.journeyapps:zxing-android-embedded:3.6.0'
-    implementation "ch.acra:acra-mail:$acraversion"
-    implementation "ch.acra:acra-notification:$acraversion"
-    implementation 'com.deploygate:sdk:4.1.0'
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'

app/src/main/AndroidManifest.xml

@@ -12,7 +12,7 @@
         android:hardwareAccelerated="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
-        android:roundIcon="@mipmap/ic_android_light_round"
+        android:roundIcon="@mipmap/ic_android_dark_round"
         android:supportsRtl="true"
         android:theme="@style/AppTheme"
         tools:ignore="GoogleAppIndexingWarning">

app/src/main/java/com/backsofangels/justreadit/JustreaditApplication.java

@@ -1,22 +1,10 @@
 package com.backsofangels.justreadit;
 
 import android.app.Application;
-import android.app.NotificationChannel;
-import android.app.NotificationManager;
-import android.content.Context;
-import android.os.Build;
-
-import org.acra.ACRA;
-import org.acra.annotation.AcraCore;
-import org.acra.annotation.AcraMailSender;
-import org.acra.annotation.AcraNotification;
 
 import io.realm.Realm;
 import io.realm.RealmConfiguration;
 
-@AcraCore(buildConfigClass = BuildConfig.class)
-@AcraMailSender(mailTo = "backsofangels@gmail.com", reportAsFile = true, reportFileName = "JustReadIt-ACRA-report.stacktrace", resSubject = R.string.acrareport_mailsubject)
-@AcraNotification(resChannelName = R.string.acrareport_notificationchannel_name, resTitle = R.string.acrareport_notification_title, resText = R.string.acrareport_notification_text)
 public class JustreaditApplication extends Application {
     //Realm DB setup
     @Override
@@ -27,26 +15,5 @@ public void onCreate() {
                 .name("justreadit.realm")
                 .build();
         Realm.setDefaultConfiguration(CONF);
-        createNotificationChannel();
-    }
-
-    //ACRA (crash report service) configuration
-    @Override
-    protected void attachBaseContext(Context base) {
-        super.attachBaseContext(base);
-        ACRA.init(this);
-    }
-
-    private void createNotificationChannel() {
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-            CharSequence name = getString(R.string.acrareport_notificationchannel_name);
-            String description = getString(R.string.acrareport_notificationchannel_description);
-            String channelId = getString(R.string.acrareport_notificationchannel_id);
-            int importance = NotificationManager.IMPORTANCE_DEFAULT;
-            NotificationChannel channel = new NotificationChannel(channelId, name, importance);
-            channel.setDescription(description);
-            NotificationManager notificationManager = getSystemService(NotificationManager.class);
-            notificationManager.createNotificationChannel(channel);
-        }
     }
 }

app/src/main/java/com/backsofangels/justreadit/persistence/ScannedLinkDao.java

@@ -56,7 +56,6 @@ public void execute(@Nonnull Realm realm) {
 
     public ArrayList<ScannedLink> retrieveLinks() {
         ArrayList<ScannedLink> queryResult = new ArrayList<>();
-        System.out.println("Retrieving");
         try {
             queryResult.addAll(r.where(ScannedLink.class).findAll());
         } catch (RealmException e) {

app/src/main/java/com/backsofangels/justreadit/ui/main/MainActivity.java

@@ -53,7 +53,6 @@ public boolean onCreateOptionsMenu(Menu menu) {
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == R.id.open_source_licenses) {
-            System.out.println("starto la nuova activity");
             Intent intent = new Intent(this, MenuActivity.class);
             startActivity(intent);
             return true;

app/src/main/java/com/backsofangels/justreadit/ui/qrcodefragment/QRCodeReaderFragment.java

@@ -37,11 +37,10 @@ public void barcodeResult(BarcodeResult result) {
                 return;
             }
             scannedText = result.getText();
-            System.out.println("Found QR. URI is " + scannedText);
             ScannedLink l = new ScannedLink(scannedText, new Date());
             dao.saveLink(l);
-            Snackbar scanDoneNotification = Snackbar.make(getView(), "Link scannerizzato!", Snackbar.LENGTH_LONG);
-            scanDoneNotification.setAction("Vedi", new ChangePageListener());
+            Snackbar scanDoneNotification = Snackbar.make(getView(), "Link scanned!", Snackbar.LENGTH_LONG);
+            scanDoneNotification.setAction("Go", new ChangePageListener());
             scanDoneNotification.show();
         }
 

app/src/main/res/values/strings.xml

@@ -4,10 +4,10 @@
     <string name="scanhistory_tab_title">Link history</string>
     <string name="acrareport_mailsubject">ACRA JustReadIt crash report</string>
     <string name="acrareport_notification_title">Just Read it crash!</string>
-    <string name="acrareport_notification_text">Ops, Just Read It è crashata. Mandami un report per risolvere il problema!</string>
+    <string name="acrareport_notification_text">Ops, Just Read It crashed. Send a report to make me investigate!</string>
     <string name="acrareport_notificationchannel_name">Crash report</string>
-    <string name="acrareport_notificationchannel_description">Notifica un crash che è poi possibile inviare allo sviluppatore</string>
+    <string name="acrareport_notificationchannel_description">Notifies a crash and generates a report that can be sent to the developer</string>
     <string name="acrareport_notificationchannel_id">ACRA_crash_report</string>
-    <string name="menu_item_licenses">Licenze open source</string>
-    <string name="licenses">Questa app è stata realizzata secondo la licenza GNU GPL 3.0.\nL\'intero codice sorgente è visualizzabile al seguente link\n<a href="https://github.com/backsofangels/justreadit">https://github.com/backsofangels/justreadit</a>\nSono state usate le librerie open source Zxing, Zxing-android-embedded ed ACRA crash reports.\nPer qualsiasi necessità, domanda o feedback, contattami all\'indirizzo\nbacksofangels@gmail.com</string>
+    <string name="menu_item_licenses">Open source licenses</string>
+    <string name="licenses">This app was developed under GNU GPL 3.0.\nThe whole source code can be seen at\n<a href="https://github.com/backsofangels/justreadit">https://github.com/backsofangels/justreadit</a>\nThe libraries Zxing, Zxing-android-embedded and ACRA crash reports have been used.\nFor every question or feedback, mail me to\nbacksofangels@gmail.com</string>
 </resources>