build(gcc): use -fhardened option for gcc14

also, switch off hardenings for debug builds

Author: b1ackviking

.github/workflows/ci.yml

@@ -98,7 +98,7 @@ jobs:
           -D ENABLE_LSAN:BOOL=${{ matrix.build.type == 'Debug' }}
           -D ENABLE_CPPCHECK:BOOL=TRUE
           -D ENABLE_CLANG_TIDY:BOOL=${{ contains(matrix.config.cc, 'clang') }}
-          -D ENABLE_HARDENINGS:BOOL=TRUE
+          -D ENABLE_HARDENINGS:BOOL=${{ matrix.build.type != 'Debug' }}
           -D ENABLE_FORTIFY_SOURCE:BOOL=${{ matrix.build.type != 'Debug' }}
 
       - name: Build
@@ -198,7 +198,7 @@ jobs:
           -D ENABLE_ASAN:BOOL=${{ matrix.build.type == 'Debug' }}
           -D ENABLE_UBSAN:BOOL=${{ matrix.build.type == 'Debug' }}
           -D ENABLE_LSAN:BOOL=${{ matrix.build.type == 'Debug' }}
-          -D ENABLE_HARDENINGS:BOOL=TRUE
+          -D ENABLE_HARDENINGS:BOOL=${{ matrix.build.type != 'Debug' }}
           -D ENABLE_FORTIFY_SOURCE:BOOL=${{ matrix.build.type != 'Debug' }}
 
       - name: Build
@@ -303,7 +303,7 @@ jobs:
           poetry run cmake --preset ${{ matrix.build.preset }}
           -D ENABLE_COVERAGE:BOOL=${{ matrix.build.type == 'Debug' }}
           -D ENABLE_ASAN:BOOL=${{ matrix.build.type == 'Debug' && matrix.config.cc == 'cl' }}
-          -D ENABLE_HARDENINGS:BOOL=TRUE
+          -D ENABLE_HARDENINGS:BOOL=${{ matrix.build.type != 'Debug' }}
 
       - name: Build
         run: cmake --build --preset ${{ matrix.build.preset }}

cmake/defaults.cmake

@@ -290,7 +290,9 @@ function(enable_hardenings target_name)
         /DYNAMICBASE
         /LARGEADDRESSAWARE
         /HIGHENTROPYVA)
-    elseif(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang|GNU")
+    elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      target_compile_options(${target_name} INTERFACE -fhardened)
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang")
       target_compile_definitions(${target_name} INTERFACE _GLIBCXX_ASSERTIONS)
       if(ENABLE_FORTIFY_SOURCE)
         target_compile_options(${target_name} INTERFACE -U_FORTIFY_SOURCE