Tidy and unified UI

[vollowx]

Straightly go to this comment.

Feature description

The highlights for cmp, nvim-tree, wilder and indent-blankline now is untidy and always catch my focus when I should focus on my code.

Additional information

I had already modified the highlights for them.

1. same appearance for cmp and wilder
2. clear appearance for bufferline and nvim-tree
3. colored indent-blankline
4. similar highlights for indent lines in nvim-tree, indent-blankline and outline of lspsaga

So I'm here to get to know if I could give a PR.

[vollowx]

update: highlight for lspsaga's outline lspsaga#1050

[charliie-dev]

@Jint-lzxy 's #676 PR should alleviate some of your issues. It's mostly from upstream, so it needs more time to finish it.

[vollowx]

You mean some of the problems are from catppuccin/nvim right? So I will wait for them :P

They other changes are not problems, they are just for customization (2, 3 and 4)

[charliie-dev]

ys, of course u can send pr about 2, 3, 4 first!

[vollowx]

pr is ready at #699

[Jint-lzxy]

@huge-pancake Many thanks for your contribution 👍 But due to the complexity of #676 (most highlight groups and actual hex codes for those antonomasias [e.g., C.base -> #1E1E2E] will undergo significant changes), hence to avoid repetitive work, this PR will be merged after #676 is completed. I will also refer to your PR while reimplementing those hl groups.

Here is a sneak peak of Telescope's new UI (based on your PR):

[vollowx]

Got it, hope #676/upstream update will come out soon.

Also there're some problems I haven't solve yet:

1. Should windows / floating window have border or not? If have, curved or not? It should be decided by users themselves, but changing all the options will be too hard and it's also hard when users want to change the UI style again. Maybe we can provide a option in settings.lua to control this. (also see catppuccin/nvim#439)
2. I'm using WinSeparator to hide border in outline (lspsaga) like nvim-tree, but this will influence all the borders between window and window. Maybe lspsaga should provide a highlight OutlineBorder. (may be solved in nvimdev/lspsaga.nvim#1054)

3. Bufferline's inactive background (default is crust) should be lighter (NvChad) than the color of the tabs or darker (default, VSCode)?

Btw, I think in the field of UI, NvChad relly does very well.

[Jint-lzxy]

Should windows / floating window have border or not?

The following is the concept I plan to adopt:

1. Border(s) should be used as a separator to distinguish between two rendering regions, as windows without border(s) still behave like having right-angled borders with hl-Normal as foreground. Hence, say if two overlapping windows won't make it hard for users to distinguish between them, the border(s) should be omitted and colors (bg) with different saturation levels should be used for differentiation. (For example, Telescope)
2. If a border is used for some reason, then:
   i. A right-angled border should be used as a "true" separator because it is less decorative than a rounded border. It should be mainly used to distinguish between two primary windows (e.g., the editor and nvim-cmp);
   ii. Rounded border(s) shall be used for other purposes, such as decorating null-ls's information window (since its highlight (bg) defaults to hl-Normal, which makes it difficult for users to distinguish between those windows).

It should be decided by users themselves

I'm not very supportive of allowing users to customize such option b/c it is difficult to manage the borders of all plugins using the same interface. Additionally, for some windows users may not want to have borders enabled, while for some other they may wish they could have different colors. However, the way(s) to configure color- and border-style for a specific window differentiates from plugins to plugins (API differences), plus the fact that those values must be supplied during initialization (using border-character or style names) - this ultimately leads to a lot of work while still making it hard to meet all the needs. IMHO If users really want to change these appearances, they should make changes to a specific config file themselves.

but this will influence all the borders between window and window

Hmm AFAIK this is impossible with nvim 0.9, as it requires low-level API support (providing an option to set window-specific hl-VertSplit when creating a new split). But let's wait and see how glepnir would handle this 😄

Bufferline's inactive background ... should be lighter ...

Actually catppuccin provides such option (dim_inactive), but this was not adopted due to several design defects. IMO now it's time to introduce this back to the config 👍

nvimdots/lua/modules/configs/ui/catppuccin.lua

Lines 7 to 13 in 3be4c9b

	dim_inactive = {
	enabled = false,
	-- Dim inactive splits/windows/buffers.
	-- NOT recommended if you use old palette (a.k.a., mocha).
	shade = "dark",
	percentage = 0.15,
	},

Btw, I think in the field of UI, NvChad relly does very well.

💯💯 Agreed. In fact, I took heavy inspiration from NvChad's UI design (as a stepping-stone for further configuration) :)

[vollowx]

1. Borders: I can accept if borders can be united, too. I just don't like united UI design :P
2. Lspsaga: waiting for the author
3. Bufferline: agree

[rewhile]

Here is a sneak peak of Telescope's new UI (based on your PR):

More than happy to merge this upstream under telescope = { nvchad = true }. However, I think the current Visual bg is a little hard to see: