Skip to content

Commit abae8e8

Browse files
committed
Align header checks
1 parent 03db37c commit abae8e8

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpServletResponse.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,19 +213,24 @@ public void addDateHeader(String s, long l) {
213213
@Override
214214
public void setHeader(String s, String s1) {
215215
if (!canSetHeader()) return;
216-
if ("Content-Type".equalsIgnoreCase(s)) {
216+
if (isContentTypeHeader(s)) {
217217
setContentType(s1);
218218
} else {
219219
setHeader(s, s1, true);
220220
}
221221
}
222222

223223

224+
private boolean isContentTypeHeader(String s) {
225+
return s.toLowerCase(Locale.getDefault()).equals(HttpHeaders.CONTENT_TYPE.toLowerCase(Locale.getDefault()));
226+
}
227+
228+
224229
@Override
225230
public void addHeader(String s, String s1) {
226231
if (!canSetHeader()) return;
227232
// TODO: We should probably have a list of headers that we are not allowed to have multiple values for
228-
if (s.toLowerCase(Locale.getDefault()).equals(HttpHeaders.CONTENT_TYPE.toLowerCase(Locale.getDefault()))) {
233+
if (isContentTypeHeader(s)) {
229234
setContentType(s1);
230235
} else {
231236
setHeader(s, s1, false);

0 commit comments

Comments
 (0)