Skip to content

Commit 84ebd2d

Browse files
committed
fix(feature-processor): Add clarifying comment for legacy env var and explicit cryptography dep
Add comment explaining REMOTE_FUNCTION_SECRET_KEY is a legacy misnomer — the value is an ECDSA public key for signature verification, not a secret. Add cryptography>=46.0.0 as explicit dependency in sagemaker-mlops. --- X-AI-Prompt: resolve CR comment about misleading REMOTE_FUNCTION_SECRET_KEY naming and missing cryptography dependency X-AI-Tool: kiro
1 parent 11dd57e commit 84ebd2d

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

sagemaker-mlops/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ dependencies = [
2626
"sagemaker-core>=2.10.1",
2727
"sagemaker-train>=1.10.1",
2828
"sagemaker-serve>=1.10.1",
29+
"cryptography>=46.0.0",
2930
"boto3>=1.42.2,<2.0",
3031
"botocore>=1.42.2,<2.0",
3132
"pyiceberg[glue]>=0.8.0",

sagemaker-mlops/src/sagemaker/mlops/feature_store/feature_processor/feature_scheduler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -871,6 +871,8 @@ def _prepare_model_trainer_from_remote_decorator_config(
871871
# Build environment dict from remote_decorator_config
872872
environment = dict(remote_decorator_config.environment_variables or {})
873873
if public_key_pem:
874+
# Legacy env var name — value is the ECDSA public key used by the container
875+
# (invoke_function.py) for asymmetric signature verification, not a secret.
874876
environment["REMOTE_FUNCTION_SECRET_KEY"] = public_key_pem
875877

876878
# Build command from container entry point and arguments

0 commit comments

Comments
 (0)