fix: remove deprecated save_turn() and process_turn() methods (#241)

* fix: remove deprecated save_turn() and process_turn() methods

Remove deprecated methods that were scheduled for removal in v1.0.0:
- save_turn(): Use save_conversation() instead
- process_turn(): Use retrieve_memories() and save_conversation() separately

Closes #234

* fix: format line length in test_client.py

---------

Signed-off-by: Trirmadura J Ariyawansa <tjariy@amazon.com>

Author: jariy17

src/bedrock_agentcore/memory/client.py

@@ -620,78 +620,6 @@ def save_conversation(
             logger.error("Failed to create event: %s", e)
             raise
 
-    def save_turn(
-        self,
-        memory_id: str,
-        actor_id: str,
-        session_id: str,
-        user_input: str,
-        agent_response: str,
-        event_timestamp: Optional[datetime] = None,
-    ) -> Dict[str, Any]:
-        """DEPRECATED: Use save_conversation() for more flexibility.
-
-        This method will be removed in v1.0.0.
-        """
-        warnings.warn(
-            "save_turn() is deprecated and will be removed in v1.0.0. "
-            "Use save_conversation() for flexible message handling.",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-
-        messages = [(user_input, "USER"), (agent_response, "ASSISTANT")]
-
-        return self.create_event(
-            memory_id=memory_id,
-            actor_id=actor_id,
-            session_id=session_id,
-            messages=messages,
-            event_timestamp=event_timestamp,
-        )
-
-    def process_turn(
-        self,
-        memory_id: str,
-        actor_id: str,
-        session_id: str,
-        user_input: str,
-        agent_response: str,
-        event_timestamp: Optional[datetime] = None,
-        retrieval_namespace: Optional[str] = None,
-        retrieval_query: Optional[str] = None,
-        top_k: int = 3,
-    ) -> Tuple[List[Dict[str, Any]], Dict[str, Any]]:
-        """DEPRECATED: Use retrieve_memories() and save_conversation() separately.
-
-        This method will be removed in v1.0.0.
-        """
-        warnings.warn(
-            "process_turn() is deprecated and will be removed in v1.0.0. "
-            "Use retrieve_memories() and save_conversation() separately, or use process_turn_with_llm().",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-
-        retrieved_memories = []
-
-        if retrieval_namespace:
-            search_query = retrieval_query or user_input
-            retrieved_memories = self.retrieve_memories(
-                memory_id=memory_id, namespace=retrieval_namespace, query=search_query, top_k=top_k
-            )
-
-        event = self.save_turn(
-            memory_id=memory_id,
-            actor_id=actor_id,
-            session_id=session_id,
-            user_input=user_input,
-            agent_response=agent_response,
-            event_timestamp=event_timestamp,
-        )
-
-        return retrieved_memories, event
-
     def process_turn_with_llm(
         self,
         memory_id: str,

tests/bedrock_agentcore/memory/test_client.py

@@ -141,7 +141,9 @@ def test_save_conversation_and_retrieve_memories():
         # Test UUID patch for deterministic testing
         with patch("uuid.uuid4", return_value=uuid.UUID("12345678-1234-5678-1234-567812345678")):
             # Test retrieve_memories
-            memories = client.retrieve_memories(memory_id="mem-123", namespace="test/namespace/", query="Hello", top_k=3)
+            memories = client.retrieve_memories(
+                memory_id="mem-123", namespace="test/namespace/", query="Hello", top_k=3
+            )
 
             assert len(memories) == 1
             assert memories[0]["memoryRecordId"] == "rec-123"
@@ -291,45 +293,6 @@ def test_timestamp_and_advanced_message_handling():
         assert kwargs.get("eventTimestamp") == custom_timestamp
 
 
-def test_deprecated_methods():
-    """Test deprecated methods with warnings."""
-    with patch("boto3.client"):
-        client = MemoryClient()
-        mock_gmdp = MagicMock()
-        client.gmdp_client = mock_gmdp
-
-        # Create responses for deprecated methods
-        mock_gmdp.create_event.return_value = {"event": {"eventId": "event-dep-1", "memoryId": "mem-123"}}
-        mock_gmdp.retrieve_memory_records.return_value = {"memoryRecordSummaries": []}
-
-        # Use warnings.catch_warnings to verify deprecation warnings
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter("always")
-
-            # Test deprecated save_turn method
-            event = client.save_turn(
-                memory_id="mem-123",
-                actor_id="user-123",
-                session_id="session-456",
-                user_input="Hello",
-                agent_response="Hi",
-            )
-
-            # Test deprecated process_turn method
-            memories, event = client.process_turn(
-                memory_id="mem-123",
-                actor_id="user-123",
-                session_id="session-456",
-                user_input="Hello",
-                agent_response="Hi",
-                retrieval_namespace="test/ns/",
-            )
-
-            assert len(w) >= 2
-            assert any("save_turn() is deprecated" in str(warning.message) for warning in w)
-            assert any("process_turn() is deprecated" in str(warning.message) for warning in w)
-
-
 def test_create_memory_and_wait_success():
     """Test successful create_memory_and_wait scenario."""
     with patch("boto3.client"):