Skip to content

Commit fece7ec

Browse files
iliapolorix0rrrmrgrain
authored
feat(cli-integ): speed up image pulls by logging into ECR public (#400)
Porting aws/aws-cdk-cli-testing#84 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license Co-authored-by: Rico Hermans <rix0rrr@gmail.com> Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
1 parent 1b1dd8d commit fece7ec

3 files changed

Lines changed: 4 additions & 0 deletions

File tree

packages/@aws-cdk-testing/cli-integ/lib/with-cdk-app.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export function withSpecificCdkApp(
5050
context.output,
5151
context.aws,
5252
context.randomString);
53+
await fixture.ecrPublicLogin();
5354

5455
let success = true;
5556
try {
@@ -123,6 +124,7 @@ export function withCdkMigrateApp(
123124
context.aws,
124125
context.randomString,
125126
);
127+
await fixture.ecrPublicLogin();
126128

127129
await ensureBootstrapped(fixture);
128130

packages/@aws-cdk-testing/cli-integ/lib/with-cli-lib.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export function withCliLibIntegrationCdkApp<A extends TestContext & AwsContext &
2929
context.output,
3030
context.aws,
3131
context.randomString);
32+
await fixture.ecrPublicLogin();
3233

3334
let success = true;
3435
try {

packages/@aws-cdk-testing/cli-integ/lib/with-sam.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export function withSamIntegrationCdkApp<A extends TestContext & AwsContext>(blo
3737
context.output,
3838
context.aws,
3939
context.randomString);
40+
await fixture.ecrPublicLogin();
4041

4142
let success = true;
4243
try {

0 commit comments

Comments
 (0)