Merge pull request #6 from ksmin23/features/langfuse-v3

ksmin23 · web-flow · commit a2dfdc36be73 · 2025-01-30T15:18:28.000+09:00
refactor codes
diff --git a/langfuse-v3/app.py b/langfuse-v3/app.py
@@ -70,7 +70,6 @@
 
 ecs_cluster_stack = ECSClusterStack(app, "LangfuseECSClusterStack",
   vpc_stack.vpc,
-  service_discovery_stack.namespace,
   env=AWS_ENV
 )
 ecs_cluster_stack.add_dependency(service_discovery_stack)
diff --git a/langfuse-v3/cdk_stacks/ecs_cluster.py b/langfuse-v3/cdk_stacks/ecs_cluster.py
@@ -14,7 +14,7 @@
 
 class ECSClusterStack(Stack):
 
-  def __init__(self, scope: Construct, construct_id: str, vpc, service_discovery_namespace, **kwargs) -> None:
+  def __init__(self, scope: Construct, construct_id: str, vpc, **kwargs) -> None:
 
     super().__init__(scope, construct_id, **kwargs)
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,6 @@`
`70`	`70`
`71`	`71`	`ecs_cluster_stack = ECSClusterStack(app, "LangfuseECSClusterStack",`
`72`	`72`	`vpc_stack.vpc,`
`73`		`- service_discovery_stack.namespace,`
`74`	`73`	`env=AWS_ENV`
`75`	`74`	`)`
`76`	`75`	`ecs_cluster_stack.add_dependency(service_discovery_stack)`