Commit b435c06
authored
Handle server side default for inputDataConfig in TrainingJob (#168)
Bug fix for unhandled case in training job. `inputDataConfig` is an optional field. Its default value is an empty list. Without this hook, the controller reconciles because of diff between null(desired) and empty list(observed) when `inputDataConfig` is not specified
- usecase: If user bundles the dataset and training code into the training image or downloads dataset at runtime
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.1 parent 553f3a4 commit b435c06
File tree
2 files changed
+8
-2
lines changed- apis/v1alpha1
- pkg/resource/training_job
2 files changed
+8
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
| |||
0 commit comments