Fix casting from empty string to number or boolean (#22)

Author: eduardomourar

python/rpdk/typescript/templates/README.md

@@ -1,4 +1,4 @@
-// {{ type_name }}
+# {{ type_name }}
 
 Congratulations on starting development! Next steps:
 

python/rpdk/typescript/templates/package.json

@@ -1,6 +1,6 @@
 {
     "name": "{{ name }}",
-    "version": "1.0.0",
+    "version": "0.1.0",
     "description": "{{ description }}",
     "main": "dist/handlers.js",
     "files": [

src/recast.ts

@@ -17,6 +17,15 @@ export const recastPrimitive = (
         // so we leave it as a string
         return v;
     }
+    if (
+        (Object.is(cls, Boolean) ||
+            Object.is(cls, Number) ||
+            Object.is(cls, BigInt) ||
+            Object.is(cls, Integer)) &&
+        v.length === 0
+    ) {
+        return null;
+    }
     if (Object.is(cls, Boolean)) {
         if (v.toLowerCase() === 'true') {
             return true;

tests/lib/recast.test.ts

@@ -31,7 +31,7 @@ describe('when recasting objects', () => {
     test('recast complex object', () => {
         const payload = {
             ListListAny: [[{ key: 'val' }]],
-            ListListInt: [['1', '2', '3']],
+            ListListInt: [['1', '2', '3', '']],
             ListSetInt: [['1', '2', '3']],
             ASet: ['1', '2', '3'],
             AnotherSet: ['a', 'b', 'c'],
@@ -63,7 +63,7 @@ describe('when recasting objects', () => {
         };
         const expected = {
             ListSetInt: [new Set([1, 2, 3])],
-            ListListInt: [[1, 2, 3]],
+            ListListInt: [[1, 2, 3, null]],
             ListListAny: [[{ key: 'val' }]],
             ASet: new Set(['1', '2', '3']),
             AnotherSet: new Set(['a', 'b', 'c']),
@@ -140,4 +140,15 @@ describe('when recasting objects', () => {
         const num = recastPrimitive(Number, k, v);
         expect(num).toBe(1252.53);
     });
+
+    test('recast primitive boolean/number empty string', () => {
+        const k = 'key';
+        const v = '';
+        const bool = recastPrimitive(Boolean, k, v);
+        const num = recastPrimitive(Number, k, v);
+        const int = recastPrimitive(BigInt, k, v);
+        expect(bool).toBeNull();
+        expect(num).toBeNull();
+        expect(int).toBeNull();
+    });
 });