Code review fixes

Author: sam-muncke

examples/ConnectedAccounts.md

@@ -22,7 +22,7 @@ server_client = ServerClient(
     secret="YOUR_SECRET",
     use_mrrt=True,
     authorization_params={
-        "redirect_uri"=:"YOUR_CALLBACK_URL",
+        "redirect_uri":"YOUR_CALLBACK_URL",
     }
 )
 ```

src/auth0_server_python/auth_server/my_account_client.py

@@ -19,7 +19,7 @@ def __init__(self, domain: str):
         self._domain = domain
 
     @property
-    def audienceIdentifier(self):
+    def audience_identifier(self):
         return f"https://{self._domain}/me/"
 
     async def connect_account(
@@ -30,7 +30,7 @@ async def connect_account(
         try:
             async with httpx.AsyncClient() as client:
                 response = await client.post(
-                    url=f"{self.audienceIdentifier}v1/connected-accounts/connect",
+                    url=f"{self.audience_identifier}v1/connected-accounts/connect",
                     json=request.model_dump(exclude_none=True),
                     auth=BearerAuth(access_token)
                 )
@@ -73,7 +73,7 @@ async def complete_connect_account(
         try:
             async with httpx.AsyncClient() as client:
                 response = await client.post(
-                    url=f"{self.audienceIdentifier}v1/connected-accounts/complete",
+                    url=f"{self.audience_identifier}v1/connected-accounts/complete",
                     json=request.model_dump(exclude_none=True),
                     auth=BearerAuth(access_token)
                 )

src/auth0_server_python/auth_server/server_client.py

@@ -576,8 +576,8 @@ async def get_session(self, store_options: Optional[dict[str, Any]] = None) -> O
 
     async def get_access_token(
         self,
-        audience = None,
-        scope = None,
+        audience: Optional[str] = None,
+        scope: Optional[str] = None,
         store_options: Optional[dict[str, Any]] = None
     ) -> str:
         """
@@ -618,7 +618,7 @@ async def get_access_token(
                 if ts.get("audience") == audience and (not scope or ts.get("scope") == scope):
                     token_set = ts
                     break
-        
+
         # After loop: if no matching token found and MRRT disabled, check if we need to error
         if not token_set and not self._use_mrrt and state_data_dict.get("token_sets"):
             # We have tokens but none match, and we can't use RT to get a new one
@@ -1347,10 +1347,10 @@ async def start_connect_account(
             code_challenge=code_challenge,
             code_challenge_method="S256",
             state=state,
-            authorization_params=options.authorization_params
+            authorization_params=auth_params or None
         )
         access_token = await self.get_access_token(
-            audience=self._my_account_client.audienceIdentifier,
+            audience=self._my_account_client.audience_identifier,
             scope="create:me:connected_accounts",
             store_options=store_options
         )
@@ -1385,7 +1385,7 @@ async def complete_connect_account(
         Handles the redirect callback to complete the connect account flow for linking a third-party
         account to the user's profile.
 
-        This works similiar to the redirect from the login flow except it verifies the `connect_code`
+        This works similar to the redirect from the login flow except it verifies the `connect_code`
         with the My Account API rather than the `code` with the Authorization Server.
 
         Args:
@@ -1420,7 +1420,7 @@ async def complete_connect_account(
             raise MissingTransactionError()
 
         access_token = await self.get_access_token(
-            audience=self._my_account_client.audienceIdentifier,
+            audience=self._my_account_client.audience_identifier,
             scope="create:me:connected_accounts",
             store_options=store_options
         )
@@ -1440,7 +1440,7 @@ async def complete_connect_account(
         if transaction_data.app_state is not None:
             response.app_state = transaction_data.app_state
 
-        # Clean up transaction data after successful login
+        # Clean up transaction data after successful account connection
         await self._transaction_store.delete(transaction_identifier, options=store_options)
 
         return response

src/auth0_server_python/auth_types/__init__.py

@@ -248,5 +248,5 @@ class CompleteConnectAccountResponse(BaseModel):
     access_type: str
     scopes: list[str]
     created_at: str
-    expires_at:  Optional[str] = None
+    expires_at: Optional[str] = None
     app_state: Optional[Any] = None