-
Notifications
You must be signed in to change notification settings - Fork 73
Non-blocking foreign IO operations on file descriptors #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rewbert
wants to merge
16
commits into
augustss:master
Choose a base branch
from
Rewbert:epoll-foreign-io
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0286be3
Linux support for non-blocking IO
Rewbert 8434f6f
remove conditional execution of test
Rewbert 2f04f88
refactor to prepare for implementations for the other platforms
Rewbert 0b1e26e
mac variant, generated
Rewbert 463d224
make test better
Rewbert e1c0f4f
test
Rewbert 2e69f43
update the test to use Client
Rewbert a7644d5
fix the test, after I broke it..
Rewbert 01806d9
move the direct mthread/runq manipulation out of the io_poll machiner…
Rewbert e76571b
potential bugfix. Tests pass
Rewbert b9ee18d
address some of Lennarts comments
Rewbert 8b344ad
replace with a simpler, but equally 'testive' test
Rewbert 53d0ddf
remove macos support. Lennart will add it himself
Rewbert 9c6ad1a
try to make the linter happy?
Rewbert 35581bf
add a return value to waitFor*FD, to notice whether MHS_IO_POLL is de…
Rewbert 58436cc
fix type issue
Rewbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| module System.IO.FD (waitForReadFD, waitForWriteFD) where | ||
|
|
||
| import Primitives | ||
|
|
||
| waitForReadFD :: Int -> IO Int | ||
| waitForReadFD = primWaitReadFD | ||
|
|
||
| waitForWriteFD :: Int -> IO Int | ||
| waitForWriteFD = primWaitWriteFD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* Copyright 2026 Robert Krook | ||
| * See LICENSE file for full license. | ||
| */ | ||
|
|
||
| /* | ||
| * OS-agnostic interface for non-blocking IO polling. | ||
| * Platform-specific implementations live in <platform>/io_poll_impl.c and | ||
| * are included into eval.c via #include "io_poll_impl.c". | ||
| * | ||
| */ | ||
|
|
||
| #define IO_POLL_READ 1 | ||
| #define IO_POLL_WRITE 2 | ||
|
|
||
| void io_init(void); | ||
| void io_poll(int timeout_ms, void (*on_ready)(void *cookie)); /* cookie is a struct mthread*, passed in from eval.c */ | ||
| void io_register(int fd, int events, void *cookie); | ||
| int io_waiter_count(void); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.