Skip to content

Commit 36069fd

Browse files
badjerclaude
andauthored
fix(server): Use tsconfig.json for serverTestHelpers rollup build (#138)
* fix(server): Use tsconfig.json for serverTestHelpers rollup build The serverTestHelpers rollup config was using `tsconfig: false` with inline compiler options, which bypassed TypeScript project references. During npm workspace publishing, this caused the build to fail to resolve the updated `@atxp/common` types (specifically the new `createSpendPermission` method on the Account type). By using the proper tsconfig.json, the build correctly follows project references and resolves workspace dependencies. Fixes publish failure: https://github.com/atxp-dev/sdk/actions/runs/21013783817 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: Remove corrupted nested @atxp packages from package-lock.json The package-lock.json had nested node_modules entries that pointed to npm registry versions instead of using local workspace packages: - packages/atxp-base/node_modules/@atxp/client - packages/atxp-base/node_modules/@atxp/common - packages/atxp-client/node_modules/@atxp/common - packages/atxp-express/node_modules/@atxp/common This caused CI typecheck to fail because it was using @atxp/common@0.10.4 which doesn't have the createSpendPermission method. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent bbb08e4 commit 36069fd

2 files changed

Lines changed: 4 additions & 68 deletions

File tree

package-lock.json

Lines changed: 1 addition & 55 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/atxp-server/rollup.config.js

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,9 @@ const serverTestHelpersConfigs = [
3535
},
3636
plugins: [
3737
typescript({
38-
tsconfig: false,
39-
compilerOptions: {
40-
target: 'es2020',
41-
module: 'esnext',
42-
lib: ['es2020', 'dom'],
43-
moduleResolution: 'node',
44-
allowSyntheticDefaultImports: true,
45-
esModuleInterop: true,
46-
skipLibCheck: true,
47-
strict: true,
48-
declaration: false,
49-
sourceMap: true
50-
}
38+
tsconfig: './tsconfig.json',
39+
declaration: false,
40+
declarationMap: false
5141
}),
5242
resolve({ preferBuiltins: true, exportConditions: ['node'] }),
5343
commonjs(),

0 commit comments

Comments
 (0)