-
Notifications
You must be signed in to change notification settings - Fork 25
Shift-keybindings on special characters not resolving #65
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
I can't decide if this is a resolver issue or a core keybindings issue really. There are a number of keys that are bound to Ctrl-Shift-[special character]. When these keys are being seen by keybinding-resolver, they no longer have the Shift in them, so often don't show a resolved mapping.
I noticed this on Ctrl-Shift-\ -- which in reality is actually ctrl-| and that's how keybinding-resolver is seeing it, so it doesn't show a mapping.
Now one fix for this, is to just put ctrl-| in keymaps instead, which now resolves properly, but at the same time atom IS responding to keymap defined as ctrl-shift-\. Which is a little odd.
I haven't dug to see if there is a way to get the key pressed vs "resulting key", but this is clearly happening different in the core key lookups.
Ctrl-Shift-8 is another example, Ctrl-* is what results.
From a usability standpoint, I guess I understand why like Ctrl-Shift-8 and Ctrl-Shift-9 are easier for a user to remember, but it really is ctrl-* and ctrl-( ;)
Capitalized letters do show up with the Shift Ctrl-Shift-P for example.
Ctrl-+ and Ctrl- -are interesting in that they are defined without listing shift, but also have matching bindings for the non-shifted keys.