Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Shift-keybindings on special characters not resolving #65

@bdowling

Description

@bdowling

Prerequisites

Description

I can't decide if this is a resolver issue or a core keybindings issue really. There are a number of keys that are bound to Ctrl-Shift-[special character]. When these keys are being seen by keybinding-resolver, they no longer have the Shift in them, so often don't show a resolved mapping.

I noticed this on Ctrl-Shift-\ -- which in reality is actually ctrl-| and that's how keybinding-resolver is seeing it, so it doesn't show a mapping.

Now one fix for this, is to just put ctrl-| in keymaps instead, which now resolves properly, but at the same time atom IS responding to keymap defined as ctrl-shift-\. Which is a little odd.

I haven't dug to see if there is a way to get the key pressed vs "resulting key", but this is clearly happening different in the core key lookups.

Ctrl-Shift-8 is another example, Ctrl-* is what results.
From a usability standpoint, I guess I understand why like Ctrl-Shift-8 and Ctrl-Shift-9 are easier for a user to remember, but it really is ctrl-* and ctrl-( ;)

Capitalized letters do show up with the Shift Ctrl-Shift-P for example.
Ctrl-+ and Ctrl- -are interesting in that they are defined without listing shift, but also have matching bindings for the non-shifted keys.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions