Take out the special config behavior in spec mode

Author: smashwilson

lib/git-shell-out-strategy.js

@@ -1007,7 +1007,7 @@ export default class GitShellOutStrategy {
     let output;
     try {
       let args = ['config'];
-      if (local || (atom.inSpecMode() && option !== 'atomGithub.test')) { args.push('--local'); }
+      if (local) { args.push('--local'); }
       args = args.concat(option);
       output = await this.exec(args);
     } catch (err) {
@@ -1025,7 +1025,7 @@ export default class GitShellOutStrategy {
   setConfig(option, value, {replaceAll, global} = {}) {
     let args = ['config'];
     if (replaceAll) { args.push('--replace-all'); }
-    if (global && (!atom.inSpecMode() || option === 'atomGithub.test')) { args.push('--global'); }
+    if (global) { args.push('--global'); }
     args = args.concat(option, value);
     return this.exec(args, {writeOperation: true});
   }

test/integration/helpers.js

@@ -42,7 +42,6 @@ export async function setup(options = {}) {
   };
 
   const atomEnv = global.buildAtomEnvironment();
-  sinon.stub(atom, 'inSpecMode').returns(false);
 
   let suiteRoot = document.getElementById('github-IntegrationSuite');
   if (!suiteRoot) {