Conversation
✨ Aspect Workflows Tasks📅 Sat May 23 03:50:07 UTC 2026 ❌ 2 failed tasks
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48a82c63ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # `run` inherits the `build` section in Bazel's rc hierarchy, so this picks | ||
| # up `common`, `build`, and `run` flags. Forwarded as-is to ctx.bazel.build. | ||
| rc_startup_flags, flags = rc.expand_all(command = "run") |
There was a problem hiding this comment.
Expand RC flags for build, not run
aspect run shells out with ctx.bazel.build(...), but this code expands .bazelrc as command = "run", which injects run-only flags into a build invocation. Bazel’s command-line reference lists flags like --script_path under Run Options (not build), so users with run entries in .bazelrc can hit unrecognized option failures before execution. This should expand build-compatible flags (or filter run-only ones) before calling build.
Useful? React with 👍 / 👎.
Changes are visible to end-users: yes
Implements an
aspect runverb for executing runnable targetsTest plan