Skip to content

feat: implement run task#1115

Open
thesayyn wants to merge 1 commit into
mainfrom
run_verb
Open

feat: implement run task#1115
thesayyn wants to merge 1 commit into
mainfrom
run_verb

Conversation

@thesayyn
Copy link
Copy Markdown
Member

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Implements an aspect run verb for executing runnable targets

Test plan

  • New test cases added

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented May 23, 2026

✨ Aspect Workflows Tasks

📅 Sat May 23 03:50:07 UTC 2026

❌ 2 failed tasks

  • ❌ format (buildifier-gha-debug) · ⏱ 15.8s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 failed in diff · Format failed (1 file needs format)
  • ❌ format (buildifier-gha-ephemeral) · ⏱ 1m 34s · 🐙 GitHub Actions · ☑️ Check
    💬 failed in diff · Format failed (1 file needs format)

⚠️ 2 flagged tasks

  • ⚠️ delivery (delivery-gha) · ⏱ 20.7s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Delivery complete (2 warn · 1 skipped)
  • ⚠️ delivery (delivery-gha-debug) · ⏱ 38.2s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Delivery complete (2 warn · 1 skipped)

✅ 14 successful tasks

  • ✅ build (build-gha) · ⏱ 24.7s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (160 built)
  • ✅ build (build-gha-debug) · ⏱ 1m · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (160 built)
  • ✅ format (format-gha) · ⏱ 15.8s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ format (format-gha-debug) · ⏱ 22s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ format (format-gha-ephemeral) · ⏱ 2m 18s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle (gazelle-from-source-gha) · ⏱ 14.2s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ gazelle (gazelle-from-source-gha-debug) · ⏱ 17.5s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ gazelle (gazelle-gha) · ⏱ 14.4s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ gazelle (gazelle-gha-debug) · ⏱ 17s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ gazelle (gazelle-gha-ephemeral) · ⏱ 34.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ lint (lint-gha) · ⏱ 14.7s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Lint complete (clean)
  • ✅ lint (lint-gha-debug) · ⏱ 14.6s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Lint complete (clean)
  • ✅ test (test-gha) · ⏱ 22.5s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (25/25 passed · 25 cached)
  • ✅ test (test-gha-debug) · ⏱ 1m 7s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (25/25 passed · 25 cached)

🔁 Reproduce

❌ format (buildifier-gha-debug · buildifier-gha-ephemeral)

aspect format \
  --on-change=fail \
  --scope=changed \
  --formatter-target=//tools/format:format-starlark \
  --base-ref=origin/main

⚠️ delivery (delivery-gha · delivery-gha-debug)

aspect delivery --mode=always --track-state=false --dry-run=true

CI ran --mode=selective; --mode=always is the off-runner equivalent (selective change detection needs the Aspect Workflows delivery state backend).

🛠️ Fix

❌ format (buildifier-gha-debug · buildifier-gha-ephemeral)

aspect format --on-change=silent --formatter-target=//tools/format:format-starlark -- \
  crates/aspect-cli/src/builtins/aspect/lib/runnable.axl

⏱ Last updated Sat May 23 03:53:01 UTC 2026 · 📊 GitHub API quota 1,646/15,000 (11% used, resets in 7m)
🚀 Powered by Aspect CLI (v0.0.0-dev)  |  Aspect Build · X · LinkedIn · YouTube

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48a82c63ea

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


# `run` inherits the `build` section in Bazel's rc hierarchy, so this picks
# up `common`, `build`, and `run` flags. Forwarded as-is to ctx.bazel.build.
rc_startup_flags, flags = rc.expand_all(command = "run")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Expand RC flags for build, not run

aspect run shells out with ctx.bazel.build(...), but this code expands .bazelrc as command = "run", which injects run-only flags into a build invocation. Bazel’s command-line reference lists flags like --script_path under Run Options (not build), so users with run entries in .bazelrc can hit unrecognized option failures before execution. This should expand build-compatible flags (or filter run-only ones) before calling build.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant