Fix missing ending of sub-trees when composites and root nodes are exited

Author: achynes

Assets/com.fluid.behavior-tree/Runtime/TaskParents/Composites/CompositeBase.cs

@@ -1,4 +1,4 @@
-namespace CleverCrow.Fluid.BTs.TaskParents.Composites {
+namespace CleverCrow.Fluid.BTs.TaskParents.Composites {
     public abstract class CompositeBase : TaskParentBase {
         public int ChildIndex { get; protected set; }
 
@@ -13,5 +13,9 @@ public override void Reset () {
 
             base.Reset();
         }
+
+        protected void NotifyChildEnd(int childEnding) {
+            Children[childEnding].End();
+        }
     }
 }

Assets/com.fluid.behavior-tree/Runtime/TaskParents/Composites/Selector.cs

@@ -1,4 +1,4 @@
-using CleverCrow.Fluid.BTs.Tasks;
+using CleverCrow.Fluid.BTs.Tasks;
 
 namespace CleverCrow.Fluid.BTs.TaskParents.Composites {
     public class Selector : CompositeBase {
@@ -10,9 +10,13 @@ protected override TaskStatus OnUpdate () {
 
                 switch (child.Update()) {
                     case TaskStatus.Success:
+                        NotifyChildEnd(ChildIndex);
                         return TaskStatus.Success;
                     case TaskStatus.Continue:
                         return TaskStatus.Continue;
+                    case TaskStatus.Failure:
+                        NotifyChildEnd(ChildIndex);
+                        break;
                 }
 
                 ChildIndex++;

Assets/com.fluid.behavior-tree/Runtime/TaskParents/Composites/SelectorRandom.cs

@@ -21,9 +21,13 @@ protected override TaskStatus OnUpdate () {
 
                 switch (child.Update()) {
                     case TaskStatus.Success:
+                        NotifyChildEnd(ChildIndex);
                         return TaskStatus.Success;
                     case TaskStatus.Continue:
                         return TaskStatus.Continue;
+                    case TaskStatus.Failure:
+                        NotifyChildEnd(ChildIndex);
+                        break;
                 }
 
                 ChildIndex++;

Assets/com.fluid.behavior-tree/Runtime/TaskParents/Composites/Sequence.cs

@@ -1,4 +1,4 @@
-using CleverCrow.Fluid.BTs.Tasks;
+using CleverCrow.Fluid.BTs.Tasks;
 
 namespace CleverCrow.Fluid.BTs.TaskParents.Composites {
     public class Sequence : CompositeBase {
@@ -9,8 +9,17 @@ protected override TaskStatus OnUpdate () {
                 var child = Children[ChildIndex];
 
                 var status = child.Update();
-                if (status != TaskStatus.Success) {
-                    return status;
+                switch (status) {
+                    case TaskStatus.Success:
+                        NotifyChildEnd(ChildIndex);
+                        break;
+                    case TaskStatus.Failure:
+                        NotifyChildEnd(ChildIndex);
+                        return status;
+                    case TaskStatus.Continue:
+                        return status;
+                    default:
+                        break;
                 }
 
                 ChildIndex++;

Assets/com.fluid.behavior-tree/Runtime/TaskParents/TaskRoot.cs

@@ -1,4 +1,4 @@
-using CleverCrow.Fluid.BTs.Tasks;
+using CleverCrow.Fluid.BTs.Tasks;
 
 namespace CleverCrow.Fluid.BTs.TaskParents {
     public class TaskRoot : TaskParentBase {
@@ -16,6 +16,8 @@ protected override TaskStatus OnUpdate () {
         }
 
         public override void End () {
+            var child = Children[0];
+            child.End();
         }
     }
 }