Skip to content

Icon Condition - Location Has "Secret Restrictions" #2414

@kvigue

Description

@kvigue

Is your feature request related to a problem? Please describe.
Historically, I've made my icons with two visibility conditions on them:

  1. I'm in combat OR
  2. The spell the icon is tracking is on cooldown

This is helpful for things like Avenger's Shield. I do not want to see the icon if I'm just chilling (not in combat, spell is not on cooldown), but I do want to see it if I'm in combat, and I also want to see it if it's on cooldown, since that might inform whether I can use it to pull the next M+ pack.

However, with the Midnight addon restrictions in M+ and PvP, the case of "Is my Avenger's Shield off cooldown as I approach the next M+ pull?" no longer works with just these restrictions, since TMW can't tell whether the spell is on cooldown in M+.

To get around this, my new set of conditions I'm using is:

  1. I'm in combat OR
  2. The spell the icon is tracking is on cooldown OR
  3. I'm in a Keystone dungeon

This works well in M+. However, I would also like this to apply to PvP (not that I do much PvPing as Prot, but it's nice on principle...) and any other situations where secret data is restricted from addons. As such, I would love to replace condition #3 with "I'm in Secret Restricted content"

Describe the solution you'd like
A new TMW "Location" condition that returns true if I'm in a place where addon Secret Restrictions are enabled. (M+, PvP, Raid Combat I think...? Not entirely sure what they all are.)

Describe alternatives you've considered
Now that my basic visibility conditions are getting more complicated, I've considered making a single "global" icon that checks whether I'm in combat OR whether I'm in a piece of secret restricted content (e.g., instance PvP, M+, etc.). Then I can have my Avenger's Shield icons show when either:

  1. The "global visibility check icon" is shown OR
  2. The spell is on cooldown

That would let me "factor out" all of the various instance checks (M+, instance PvP, etc.) into one place, which would make maintaining them and adding new types of content easier.

Additional context
Sample Avenger's Shield icon, just to make what I described above concrete:

!TMW1!jVHLTgIxFBX5C11I3Ag7NDExJMaUmc4ADpQww0tjTKV1aBxa0imMbFzwF7oD3PgFfpMfgIlxY2cgxAUm3lVvzzm359wuTDUZUpP1BDcJVvit7PZF5LEBlUvT01CpJ0RARMQrhuCEKSZ4+JqaJZhloGoReLuvSWe7deg4hllCQyqxErL4dA4BJ0gWUcOs4QGtgzHlPpVHYcbtMxqQ9CJRVi9h1/VQDTqwBZ2tesDT1Y0zjz6q5faJFtQXKpynVp4qgLMBTkyXN8cKMLyWV7Md1IYJ3Wwbbr2J+Cbh76jrcMWmZZnNxt/hSi3M/RGWZPffCle/zTgN0v9V1JK4jPuZtib09VIATyGXKj3GD+tUthiNZslvzivxlhw8ESPV2feq7YLSfZD0heMrdHobdU9Q2WjCmBdOPzu5a1fh3kOYPYzZ8YzCMX4Yg6jXtfMT/zBXKDFCs/ncjaWJiobTGQTBsI+/Lz6e43qZQ0MEQpbv10VW+NfZjg05vgsoWdpjKkO92L2d9wP0Aw==!

!TMW1!hZBNTsMwFIRJTsAaFniFYAdIbLJz4yZNq8QVSSk/Qsg0D2o1tSv7pU3YcRXanIGLcQAKkUBiAdv5pPk0s3Gu9rN47CFUWIhal+id3vDz+9X1GY/8EcN6Af0fGC7BWKnV3s7bAWe5QNE4TUjVZKqNfXmlNaGVk/haWTRCqrHMcfrOEjEHHkgjSCqUJZ1CTGb9FI1UT58oSMr5AxiWymfYdZsgnUlFbdfXpcLv7jWt3O5CS4WDDs8yHl9EYS+LDRQC5RKGv8m/0hS3gR0weBRlgdl24vC2zbyezOHo5PiOhaOI/fkPVe6X6NIHhWBIu4QckrbpAw==!

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions