Jedis Pool Metrics Missing for Some Services

[deverton]

The Jedis connection pool metrics show up for Kayenta but not for other services like Fiat.

Fiat:

spinnaker@spin-fiat-bb6bcb649-mfldg:/$ wget -q -O - localhost:7003/aop-prometheus | grep -i pool | grep TYPE
spinnaker@spin-fiat-bb6bcb649-mfldg:/$

Kayenta

bash-5.0$  wget -q -O - localhost:8090/aop-prometheus | grep -i pool | grep TYPE
# TYPE threadpool_maximumPoolSize gauge
# TYPE threadpool_blockingQueueSize gauge
# TYPE threadpool_corePoolSize gauge
# TYPE redis_connectionPool_numWaiters gauge
# TYPE redis_connectionPool_minIdle gauge
# TYPE redis_connectionPool_numActive gauge
# TYPE threadpool_poolSize gauge
# TYPE threadpool_activeCount gauge
# TYPE redis_connectionPool_maxIdle gauge
# TYPE redis_connectionPool_numIdle gauge

[jasonmcintosh]

FYI this isn't forgotten and is an issue we have to address - just been not been a priority yet to diagnose unfortunately.... we'd welcome any contributions!

[massimo-pacher-tw]

I've stumbled upon the same issue but I've not fixed it yet, cause we're using SQL storage in most of the services, so would need to see how many services are affected.

The class generating those metrics live in orca, and it seems to be pulled in by kayenta only ( fiat and gate don't).

That's why you can't see redis pool metrics.

The ideal solution - to keep it DRY - would be to move that class to kork telemetry I guess, cause it wouldn't make sense to pull in orca-redis on those services just for the sake of an instrumentation class.

Let me know what you think, I'll keep you posted when I manage to work on it.

[dbyron-sf]

Or perhaps in kork-jedis ?

[jasonmcintosh]

Yeah we use SQL almost exclusively so NOT been a HUGE priority... very much appreciate the dig & input!!