edit: Stores private serialization options as non-local variables instead of initializing it every time the serialize and deserialize function has been called in JsonConfigurationSerializer

Author: practicemedicine

src/AridityTeam.Ascorbic/AridityTeam.Ascorbic.csproj

@@ -41,6 +41,7 @@
 			- Addition: HttpClient.GetStringAsync(string?, CancellationToken) extension (in AridityTeam.Net)
 			- Addition: HttpClient.GetStringAsync(Uri?, CancellationToken) extension (in AridityTeam.Net)
 			- Modified: LoggerSettings is made to be serializable now
+			- Modified: Stores private serialization options as non-local variables instead of initializing it every time the serialize and deserialize function has been called in JsonConfigurationSerializer
 			- Modified: StreamEx.CopyToAsync now throws an TaskCanceledException instead of a OperationCanceledException
 			- Modified: The internal HttpClient variable inside of StreamEx will now automatically dispose itself
 			- Modified: Fix the StreamReaderEx class not being public

src/AridityTeam.Ascorbic/Configuration/JsonConfigurationSerializer.cs

@@ -36,6 +36,24 @@ namespace AridityTeam.Configuration
     public class JsonConfigurationSerializer<T> : ConfigurationSerializerBase<T>
         where T : class, new()
     {
+        private readonly IJsonTypeInfoResolver _typeInfoResolver;
+        private readonly JsonSerializerOptions _serializerOptions;
+        private readonly JsonTypeInfo _typeInfo;
+
+        /// <summary>
+        /// Initializes a new instance of the <seealso cref="JsonConfigurationSerializer{T}"/> class.
+        /// </summary>
+        public JsonConfigurationSerializer()
+        {
+            _typeInfoResolver = new DefaultJsonTypeInfoResolver();
+            _serializerOptions = new JsonSerializerOptions(JsonSerializerOptions.Default);
+            _serializerOptions.TypeInfoResolver = _typeInfoResolver;
+
+            var typeInfo = _typeInfoResolver.GetTypeInfo(typeof(T), _serializerOptions);
+            Assumes.NotNull(typeInfo);
+            _typeInfo = typeInfo;
+        }
+
         /// <summary>
         /// Deserializes the specified configuration instance.
         /// </summary>
@@ -53,12 +71,7 @@ public override async Task<T> DeserializeConfigAsync(Stream stream, Cancellation
             if (stream.Length == 0)
                 return new T();
 
-            var typeInfoResolver = new DefaultJsonTypeInfoResolver();
-            var serializationOptions = new JsonSerializerOptions();
-            serializationOptions.TypeInfoResolver = typeInfoResolver;
-
-            var typeInfo = typeInfoResolver.GetTypeInfo(typeof(T), serializationOptions);
-            var result = await JsonSerializer.DeserializeAsync(stream, typeInfo, token).AsTask();
+            var result = await JsonSerializer.DeserializeAsync(stream, _typeInfo, token).AsTask();
             Assumes.NotNull(result);
             return (T)result;
         }
@@ -77,12 +90,7 @@ public override Task SerializeConfigAsync(T newConfig, Stream stream, Cancellati
 
             Assumes.True(stream.CanWrite, SR.CannotWriteToStream);
 
-            var typeInfoResolver = new DefaultJsonTypeInfoResolver();
-            var serializationOptions = new JsonSerializerOptions();
-            serializationOptions.TypeInfoResolver = typeInfoResolver;
-
-            var typeInfo = typeInfoResolver.GetTypeInfo(typeof(T), serializationOptions);
-            return JsonSerializer.SerializeAsync(stream, newConfig, typeInfo, token);
+            return JsonSerializer.SerializeAsync(stream, newConfig, _typeInfo, token);
         }
     }
 }