Remove TestWipeoutBuildPathIfBuildOptionsChangedBuildOptionsMatch test

Build options json is not the optimal way to discover if something has changed in the build. Commit 19751fe#diff-f796a16acff0c78b88ffe6618745edc6R67 enforces the check and also wipes if the core has changed "in place".

Wiping more often gives better confidence that the actual compliation results reflect the backing storage situation.

Author: facchinm

src/arduino.cc/builder/test/wipeout_build_path_if_build_options_changed_test.go

@@ -30,14 +30,15 @@
 package test
 
 import (
+	"os"
+	"path/filepath"
+	"testing"
+
 	"arduino.cc/builder"
 	"arduino.cc/builder/gohasissues"
 	"arduino.cc/builder/types"
 	"arduino.cc/builder/utils"
 	"github.com/stretchr/testify/require"
-	"os"
-	"path/filepath"
-	"testing"
 )
 
 func TestWipeoutBuildPathIfBuildOptionsChanged(t *testing.T) {
@@ -100,34 +101,3 @@ func TestWipeoutBuildPathIfBuildOptionsChangedNoPreviousBuildOptions(t *testing.
 	_, err = os.Stat(filepath.Join(buildPath, "should_not_be_deleted.txt"))
 	NoError(t, err)
 }
-
-func TestWipeoutBuildPathIfBuildOptionsChangedBuildOptionsMatch(t *testing.T) {
-	ctx := &types.Context{}
-
-	buildPath := SetupBuildPath(t, ctx)
-	defer os.RemoveAll(buildPath)
-
-	ctx.BuildOptionsJsonPrevious = "{ \"old\":\"old\" }"
-	ctx.BuildOptionsJson = "{ \"old\":\"old\" }"
-
-	utils.TouchFile(filepath.Join(buildPath, "should_not_be_deleted.txt"))
-
-	commands := []types.Command{
-		&builder.WipeoutBuildPathIfBuildOptionsChanged{},
-	}
-
-	for _, command := range commands {
-		err := command.Run(ctx)
-		NoError(t, err)
-	}
-
-	_, err := os.Stat(buildPath)
-	NoError(t, err)
-
-	files, err := gohasissues.ReadDir(buildPath)
-	NoError(t, err)
-	require.Equal(t, 1, len(files))
-
-	_, err = os.Stat(filepath.Join(buildPath, "should_not_be_deleted.txt"))
-	NoError(t, err)
-}