Hi i'm starting to use your project v4 and I stumbled upon a couple of inconsistencies, or maybe I'm just misunderstanding something.. Let me know if you'd welcome a PR to address my uncertainties.
Why would we want to high-prio init PreventAccessFromUnwantedDomains if we're only using InitializeTenancyByRequestData?
|
$tenancyMiddleware = array_merge([Middleware\PreventAccessFromUnwantedDomains::class], config('tenancy.identification.middleware')); |
It also seems UsableWithEarlyIdentification->shouldBeSkipped() is checking for Tenancy::routeIsUniversal($route), so here the second condition is not necessary?
|
if ($this->shouldBeSkipped($route) || tenancy()->routeIsUniversal($route)) { |
Hi i'm starting to use your project v4 and I stumbled upon a couple of inconsistencies, or maybe I'm just misunderstanding something.. Let me know if you'd welcome a PR to address my uncertainties.
Why would we want to high-prio init
PreventAccessFromUnwantedDomainsif we're only usingInitializeTenancyByRequestData?tenancy/assets/TenancyServiceProvider.stub.php
Line 252 in 0cd0bc4
It also seems
UsableWithEarlyIdentification->shouldBeSkipped()is checking forTenancy::routeIsUniversal($route), so here the second condition is not necessary?tenancy/src/Middleware/PreventAccessFromUnwantedDomains.php
Line 34 in 0cd0bc4