Use and definition of operative temperature for set temperature

[morea0valentin]

Hi @pjayathissa !

Thanks a lot for this awesome and very well documented code!

I've explored and tested the code which run with no issue. My remarks is the following:

In building_physics.py, function has_demand the attribute t_air is used whereas ISO 13790 suggest to use operative temperature (cf. 13.3.3 of the latter)

Furthermore the definition of the operative temperature is ambigious is the ISO 13790 regarding the value of gamme (the coefficient to define operative temperature as a linear interpolation between radiant temperature of walls T_s and air temperature T_air) Appart from one mention of a gamma value of 0.3 (the value you use in the implementation) the value of 0.5 is otherwised mention (ISO 13790 3.3.2, 13.2.3) and seems more coherent with litterature.

I would suggest:

• to let the user choose wheter or not the operative temperature or the air temperature is used as a set point
• to add the value of gamma as an hyperparemeters so that the user can chose the value.

What do you think? You may also have further insight on this that I don't know :)

Val

[pjayathissa]

Thanks for this comment! I don't have the capacity to make this change right now, but if you, or someone else has time to make a PR then I will be happy to review. Please note that along with making the change, additional unit tests will also be required to test this