test case for signal snder zombie process

Author: ramunasd

PhpAmqpLib/Connection/Heartbeat/SIGHeartbeatSender.php

@@ -20,7 +20,7 @@ final class SIGHeartbeatSender extends AbstractSignalHeartbeatSender
     private $signal;
 
     /**
-     * @var int|null the PID (process ID) of the child process sending regular signals to manage heartbeats
+     * @var int the PID (process ID) of the child process sending regular signals to manage heartbeats
      */
     private $childPid;
 
@@ -58,7 +58,7 @@ public function unregister(): void
             posix_kill($this->childPid, SIGKILL);
             pcntl_waitpid($this->childPid, $status);
         }
-        $this->childPid = null;
+        $this->childPid = 0;
     }
 
     private function registerListener(int $interval): void
@@ -84,7 +84,7 @@ private function periodicAlarm(int $interval): void
                 $slept = sleep($interval);
                 if ($slept !== 0) {
                     // interupted by signal from parent, exit immediately
-                    exit;
+                    die;
                 }
                 posix_kill($parent, $this->signal);
             }

tests/Functional/Connection/Heartbeat/SIGHeartbeatSenderTest.php

@@ -93,6 +93,7 @@ public function heartbeat_should_interrupt_non_blocking_action()
 
     /**
      * @test
+     * @runInSeparateProcess
      */
     public function alarm_sig_should_be_registered_when_conn_is_writing()
     {
@@ -101,7 +102,7 @@ public function alarm_sig_should_be_registered_when_conn_is_writing()
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
 
-        $connection->expects($this->exactly(3))->method('isConnected')->willReturn(true);
+        $connection->expects($this->atLeast(2))->method('isConnected')->willReturn(true);
         $connection->expects($this->once())->method('getHeartbeat')->willReturn($this->heartbeatTimeout);
         $connection->expects($this->exactly(2))
             ->method('isWriting')
@@ -120,4 +121,26 @@ public function alarm_sig_should_be_registered_when_conn_is_writing()
 
         $sender->unregister();
     }
+
+    /**
+     * @test
+     * @runInSeparateProcess
+     * @outputBuffering disabled
+     * @covers \PhpAmqpLib\Connection\Heartbeat\SIGHeartbeatSender::unregister()
+     */
+     public function child_process_must_be_terminated_after_unregister()
+     {
+         $property = new \ReflectionProperty(get_class($this->sender), 'childPid');
+         $property->setAccessible(true);
+
+         $this->sender->register();
+         $pid = $property->getValue($this->sender);
+         self::assertGreaterThan(0, $pid);
+
+         $this->sender->unregister();
+
+         $result = pcntl_waitpid($pid, $status, WNOHANG);
+         self::assertEquals(-1, $result);
+         self::assertEquals(0, $status);
+     }
 }