Skip to content

Commit 52dd0c7

Browse files
committed
small updates and adding .ConfigureAwait(false) to ApiClient.cs
1 parent 6360cf1 commit 52dd0c7

5 files changed

Lines changed: 16 additions & 27 deletions

File tree

src/EssSharp.Abstractions/Concrete/EssJobBuildDimensionOptions.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ namespace EssSharp
77
{
88
public class EssJobBuildDimensionOptions : EssJobOptions, IEssJobOptions
99
{
10-
/// <summary />
11-
public EssJobBuildDimensionOptions() : base(EssJobType.Dimbuild)
12-
{
13-
}
14-
1510
/// <summary />
1611
public EssJobBuildDimensionOptions( string dataFilePath = null, string ruleFilePath = null, string applicationName = null, string connection = null, string cubeName = null, bool? forceDimBuild = null, string password = null, EssRestructureOption? restructureOption = null, string username = null ) : base(EssJobType.Dimbuild)
1712
{

src/EssSharp.Abstractions/Concrete/EssJobLoadDataOptions.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@ namespace EssSharp
77
/// <summary />
88
public class EssJobLoadDataOptions : EssJobOptions, IEssJobOptions
99
{
10-
/// <summary />
11-
public EssJobLoadDataOptions() : base(EssJobType.Dataload)
12-
{
13-
14-
}
15-
1610
/// <summary />
1711
public EssJobLoadDataOptions(string dataFilePath = null, string ruleFilePath = null, string applicationName = null, string cubeName = null, bool? abortOnError = false, string connection = null, string password = null, string username = null ) : base(EssJobType.Dataload)
1812
{

src/EssSharp.Integration/PerformServerOperationTests.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1790,7 +1790,7 @@ public async Task Essbase_AfterDefaultGrid_CanBuildDimension_File()
17901790
Assert.Equal(EssJobStatus.Completed, job.JobStatus);
17911791
}
17921792

1793-
[Fact(DisplayName = @"PerformServerFunctionTests - 49 - Essbase_AfterDefaultGrid_CanBuildDimension_Datasource"), Priority(48)]
1793+
[Fact(DisplayName = @"PerformServerFunctionTests - 49 - Essbase_AfterDefaultGrid_CanBuildDimension_Datasource"), Priority(49)]
17941794
public async Task Essbase_AfterDefaultGrid_CanBuildDimension_Datasource()
17951795
{
17961796
// Get an unconnected server.
@@ -1813,7 +1813,7 @@ public async Task Essbase_AfterDefaultGrid_CanBuildDimension_Datasource()
18131813
Assert.Equal("Unable to successfully execute dimension build job.", exception.Message);
18141814
}
18151815

1816-
[Fact(DisplayName = @"PerformServerFunctionTests - 50 - Essbase_AfterDefaultGrid_CanBuildDimension_SQL_NamedConnection"), Priority(48)]
1816+
[Fact(DisplayName = @"PerformServerFunctionTests - 50 - Essbase_AfterDefaultGrid_CanBuildDimension_SQL_NamedConnection"), Priority(50)]
18171817
public async Task Essbase_AfterDefaultGrid_CanBuildDimension_SQL_NamedConnection()
18181818
{
18191819
// Get an unconnected server.
@@ -1836,7 +1836,7 @@ public async Task Essbase_AfterDefaultGrid_CanBuildDimension_SQL_NamedConnection
18361836
Assert.Contains("Unable to successfully execute dimension build job.", exception.Message);
18371837
}
18381838

1839-
[Fact(DisplayName = @"PerformServerFunctionTests - 51 - Essbase_AfterDefaultGrid_CanBuildDimension_SQL"), Priority(48)]
1839+
[Fact(DisplayName = @"PerformServerFunctionTests - 51 - Essbase_AfterDefaultGrid_CanBuildDimension_SQL"), Priority(51)]
18401840
public async Task Essbase_AfterDefaultGrid_CanBuildDimension_SQL()
18411841
{
18421842
// Get an unconnected server.
@@ -1859,7 +1859,7 @@ public async Task Essbase_AfterDefaultGrid_CanBuildDimension_SQL()
18591859
Assert.Equal("Unable to successfully execute dimension build job.", exception.Message);
18601860
}
18611861

1862-
[Fact(DisplayName = @"PerformServerFunctionTests - 52 - Essbase_AfterDefaultGrid_CanLoadDimension_File"), Priority(48)]
1862+
[Fact(DisplayName = @"PerformServerFunctionTests - 52 - Essbase_AfterDefaultGrid_CanLoadDimension_File"), Priority(52)]
18631863
public async Task Essbase_AfterDefaultGrid_CanLoadDimension_File()
18641864
{
18651865
// Get an unconnected server.
@@ -1880,7 +1880,7 @@ public async Task Essbase_AfterDefaultGrid_CanLoadDimension_File()
18801880
Assert.Equal(EssJobStatus.Completed, job.JobStatus);
18811881
}
18821882

1883-
[Fact(DisplayName = @"PerformServerFunctionTests - 53 - Essbase_AfterDefaultGrid_CanLoadDimension_Datasource"), Priority(48)]
1883+
[Fact(DisplayName = @"PerformServerFunctionTests - 53 - Essbase_AfterDefaultGrid_CanLoadDimension_Datasource"), Priority(53)]
18841884
public async Task Essbase_AfterDefaultGrid_CanLoadDimension_Datasource()
18851885
{
18861886
// Get an unconnected server.
@@ -1903,7 +1903,7 @@ public async Task Essbase_AfterDefaultGrid_CanLoadDimension_Datasource()
19031903
Assert.Equal("Unable to successfully execute data load job. Cannot async import to cube. null", exception.Message);
19041904
}
19051905

1906-
[Fact(DisplayName = @"PerformServerFunctionTests - 54 - Essbase_AfterDefaultGrid_CanLoadData_SQL_NamedConnection"), Priority(48)]
1906+
[Fact(DisplayName = @"PerformServerFunctionTests - 54 - Essbase_AfterDefaultGrid_CanLoadData_SQL_NamedConnection"), Priority(54)]
19071907
public async Task Essbase_AfterDefaultGrid_CanloadData_SQL_NamedConnection()
19081908
{
19091909
// Get an unconnected server.
@@ -1924,7 +1924,7 @@ public async Task Essbase_AfterDefaultGrid_CanloadData_SQL_NamedConnection()
19241924
Assert.Contains("Unable to successfully execute data load job", exception.Message);
19251925
}
19261926

1927-
[Fact(DisplayName = @"PerformServerFunctionTests - 55 - Essbase_AfterDefaultGrid_CanLoadData_SQL"), Priority(48)]
1927+
[Fact(DisplayName = @"PerformServerFunctionTests - 55 - Essbase_AfterDefaultGrid_CanLoadData_SQL"), Priority(55)]
19281928
public async Task Essbase_AfterDefaultGrid_CanLoadData_SQL()
19291929
{
19301930
// Get an unconnected server.
@@ -1948,7 +1948,7 @@ public async Task Essbase_AfterDefaultGrid_CanLoadData_SQL()
19481948
Assert.Equal("Unable to successfully execute data load job. Failed to Establish Connection With SQL Database Server. See log for more information", exception.Message);
19491949
}
19501950

1951-
[Fact(DisplayName = @"PerformServerFunctionTests - 56 - Essbase_AfterScriptCreation_CanGetMdxQueryReportWithTypes"), Priority(49)]
1951+
[Fact(DisplayName = @"PerformServerFunctionTests - 56 - Essbase_AfterScriptCreation_CanGetMdxQueryReportWithTypes"), Priority(56)]
19521952
public async Task Essbase_AfterScriptCreation_CanGetMdxQueryReportWithTypes()
19531953
{
19541954
// Get an unconnected server.
@@ -1977,7 +1977,7 @@ public async Task Essbase_AfterScriptCreation_CanGetMdxQueryReportWithTypes()
19771977
Assert.Equal(2, report.Types[2, 1]);
19781978
}
19791979

1980-
[Fact(DisplayName = @"PerformServerFunctionTests - 57 - Essbase_AfterScriptCreation_CanGetMdxQueryReportWithDimensionProperties"), Priority(50)]
1980+
[Fact(DisplayName = @"PerformServerFunctionTests - 57 - Essbase_AfterScriptCreation_CanGetMdxQueryReportWithDimensionProperties"), Priority(57)]
19811981
public async Task Essbase_AfterScriptCreation_CanGetMdxQueryReportWithDimensionProperties()
19821982
{
19831983
// Get an unconnected server.
@@ -2011,7 +2011,7 @@ public async Task Essbase_AfterScriptCreation_CanGetMdxQueryReportWithDimensionP
20112011
Assert.Equal(2, report.Types[2, 4]);
20122012
}
20132013

2014-
[Fact(DisplayName = @"PerformServerFunctionTests - 58 - Essbase_AfterDefaultGrid_CanRefreshGridWithEmptyRow"), Priority(51)]
2014+
[Fact(DisplayName = @"PerformServerFunctionTests - 58 - Essbase_AfterDefaultGrid_CanRefreshGridWithEmptyRow"), Priority(58)]
20152015
public async Task Essbase_AfterDefaultGrid_CanRefreshGridWithEmptyRow()
20162016
{
20172017
// Get an unconnected server.

src/EssSharp/Client/ApiClient.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ private async Task<ApiResponse<T>> ExecClientAsync<T>(Func<RestClient, Task<Rest
503503
// Allow any custom extensions to process the request before dispatch.
504504
await InterceptRequestAsync(request, configuration, options, cancellationToken).ConfigureAwait(false);
505505

506-
RestResponse<T> response = await getResponse(client);
506+
RestResponse<T> response = await getResponse(client).ConfigureAwait(false);
507507

508508
// if the response type is oneOf/anyOf, call FromJSON to deserialize the data
509509
if (typeof(AbstractOpenAPISchema).IsAssignableFrom(typeof(T)))
@@ -583,7 +583,7 @@ private async Task<RestResponse<T>> DeserializeRestResponseFromPolicyAsync<T>(Re
583583
{
584584
if (policyResult.Outcome == OutcomeType.Successful)
585585
{
586-
return await client.Deserialize<T>(policyResult.Result, cancellationToken);
586+
return await client.Deserialize<T>(policyResult.Result, cancellationToken).ConfigureAwait(false);
587587
}
588588
else
589589
{
@@ -640,7 +640,7 @@ private ApiResponse<T> Exec<T>(RestRequest request, RequestOptions options, IRea
640640
{
641641
var policy = RetryConfiguration.AsyncRetryPolicy;
642642
var policyResult = await policy.ExecuteAndCaptureAsync((ct) => client.ExecuteAsync(request, ct), cancellationToken).ConfigureAwait(false);
643-
return await DeserializeRestResponseFromPolicyAsync<T>(client, request, policyResult, cancellationToken);
643+
return await DeserializeRestResponseFromPolicyAsync<T>(client, request, policyResult, cancellationToken).ConfigureAwait(false);
644644
}
645645
else
646646
{

templates/ApiClient.mustache

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ namespace {{packageName}}.Client
522522
// Allow any custom extensions to process the request before dispatch.
523523
await InterceptRequestAsync(request, configuration, options, cancellationToken).ConfigureAwait(false);
524524
525-
RestResponse<T> response = await getResponse(client);
525+
RestResponse<T> response = await getResponse(client).ConfigureAwait(false);
526526
527527
// if the response type is oneOf/anyOf, call FromJSON to deserialize the data
528528
if (typeof(AbstractOpenAPISchema).IsAssignableFrom(typeof(T)))
@@ -602,7 +602,7 @@ namespace {{packageName}}.Client
602602
{
603603
if (policyResult.Outcome == OutcomeType.Successful)
604604
{
605-
return await client.Deserialize<T>(policyResult.Result, cancellationToken);
605+
return await client.Deserialize<T>(policyResult.Result, cancellationToken).ConfigureAwait(false);
606606
}
607607
else
608608
{
@@ -661,7 +661,7 @@ namespace {{packageName}}.Client
661661
{
662662
var policy = RetryConfiguration.AsyncRetryPolicy;
663663
var policyResult = await policy.ExecuteAndCaptureAsync((ct) => client.ExecuteAsync(request, ct), cancellationToken).ConfigureAwait(false);
664-
return await DeserializeRestResponseFromPolicyAsync<T>(client, request, policyResult, cancellationToken);
664+
return await DeserializeRestResponseFromPolicyAsync<T>(client, request, policyResult, cancellationToken).ConfigureAwait(false);
665665
}
666666
else
667667
{

0 commit comments

Comments
 (0)