Commit b66f94a
authored
[Fix] Fix two regressions in Converter (#16)
[Fix] Fix two regressions in Converter
### Motivation
Found two regressions with the signature of two of the ~50 converter helper methods:
- optional request body of type data
- required header fields of type JSON
### Modifications
Fixed up these signatures.
### Result
Now a project which has both can build.
### Test Plan
Used a test project for finding and fixing these. We should think about increasing the integration test coverage, and run it on runtime PRs.
Reviewed by: simonjbeaumont
Builds:
✔︎ pull request validation (5.8) - Build finished.
✔︎ pull request validation (5.9) - Build finished.
✔︎ pull request validation (nightly) - Build finished.
✔︎ pull request validation (soundness) - Build finished.
#161 parent 2c093b0 commit b66f94a
File tree
2 files changed
+4
-4
lines changed- Sources/OpenAPIRuntime/Conversion
2 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
| 250 | + | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
275 | | - | |
| 274 | + | |
| 275 | + | |
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
| |||
0 commit comments