Clean up stale CI badge and redundant auto-config#48
Open
Forbiddem wants to merge 1 commit into
Open
Conversation
The CircleCI badge in README.adoc has been broken since CI moved to GitHub Actions (apple#19) and the CircleCI config was removed (apple#20). Other apple/pkl-* repos do not carry a CI status badge in their README, so drop it rather than substitute a new one. PklAutoConfiguration is already declared in META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports since apple#16, which makes the matching EnableAutoConfiguration entry in spring.factories redundant. The PropertySourceLoader entry is preserved because Spring Boot still loads PropertySourceLoader implementations exclusively from spring.factories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small post-CI-migration cleanups:
README.adoc: The CircleCI badge has been broken since CI was moved to GitHub Actions in Move CI to GitHub actions #19 and the CircleCI config reference was removed in Remove broken reference to Circle CI #20. Otherapple/pkl-*repositories (pkl,pkl-go,pkl-k8s,pkl-pantry,pkl-intellij) do not display a CI status badge in their README, so this PR drops the badge rather than substituting a GitHub Actions one — keeping the family of repos consistent.META-INF/spring.factories:PklAutoConfigurationis already declared inMETA-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.importssince fixed org.pkl.spring.boot.PklAutoConfiguration for Spring Boot 3.x #16. The matchingEnableAutoConfiguration=entry inspring.factoriesis therefore redundant — Spring Boot 3 prefers the new imports file. ThePropertySourceLoader=entry is kept untouched, because Spring Boot still loadsPropertySourceLoaderimplementations exclusively fromspring.factories.Test plan
README.adocchange is documentation-only; renders cleanly.spring.factoriesstill contains thePropertySourceLoaderline — verified viagrep -rn 'PklAutoConfiguration\|PklPropertySourceLoader' src/.ConfigTeststill passes (no behavioural change expected — the new-style imports file already drives auto-configuration since fixed org.pkl.spring.boot.PklAutoConfiguration for Spring Boot 3.x #16).