ci: Update workflows (#36)

Author: mykola-mokhnach

.github/dependabot.yml

@@ -9,3 +9,12 @@ updates:
   commit-message:
     prefix: "chore"
     include: "scope"
+- package-ecosystem: "github-actions"
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "11:00"
+  open-pull-requests-limit: 10
+  commit-message:
+    prefix: "chore"
+    include: "scope"

.github/workflows/pr-title.yml

@@ -1,15 +1,10 @@
 name: Conventional Commits
 on:
   pull_request:
-
+    types: [opened, edited, synchronize, reopened]
 
 jobs:
   lint:
-    name: https://www.conventionalcommits.org
-    runs-on: ubuntu-latest
-    steps:
-      - uses: beemojs/conventional-pr-action@v2
-        with:
-          config-preset: angular
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    uses: appium/appium-workflows/.github/workflows/pr-title.yml@main
+    with:
+      config-preset: angular

.github/workflows/publish.js.yml.disabled

@@ -0,0 +1,42 @@
+# Reenable this workflow as soon as the project is moved under the Appium org in npmjs
+
+name: Release
+
+on:
+  workflow_dispatch:
+  push:
+    branches: [ master ]
+
+permissions:
+  contents: write
+  pull-requests: write
+  issues: write
+  id-token: write # to enable use of OIDC for trusted publishing and npm provenance
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js
+      uses: actions/setup-node@v3
+      with:
+        node-version: lts/*
+    - run: npm install --no-package-lock
+      name: Install dependencies
+    - run: npm run test
+      name: Run NPM Test
+    - run: |
+        rm -rf package-lock.json node_modules
+        # Remove dev dependencies from node_modules
+        npm prune --omit=dev --no-package-lock
+      name: Remove dev dependencies
+    - run: npm shrinkwrap --omit=dev
+      name: Create shrinkwrap
+    - run: npm install --only=dev --no-package-lock
+      name: Install dev dependencies for the release
+    - run: npx semantic-release
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      name: Release
+

.github/workflows/unit-test.yml

@@ -1,31 +1,40 @@
 name: Unit Tests
 
-on: [pull_request, push]
+on:
+  pull_request:
+    branches: [ master ]
+    paths-ignore:
+    - 'docs/**'
+    - '*.md'
+  push:
+    branches: [ master ]
+    paths-ignore:
+    - 'docs/**'
+    - '*.md'
 
 
 jobs:
-  prepare_matrix:
-    runs-on: ubuntu-latest
-    outputs:
-      versions: ${{ steps.generate-matrix.outputs.versions }}
-    steps:
-    - name: Select 3 most recent LTS versions of Node.js
-      id: generate-matrix
-      run: echo "versions=$(curl -s https://endoflife.date/api/nodejs.json | jq -c '[[.[] | select(.lts != false)][:3] | .[].cycle | tonumber]')" >> "$GITHUB_OUTPUT"
+  node_matrix:
+    uses: appium/appium-workflows/.github/workflows/node-lts-matrix.yml@main
 
   test:
     needs:
-    - prepare_matrix
+    - node_matrix
     strategy:
+      fail-fast: false
       matrix:
-        node-version: ${{ fromJSON(needs.prepare_matrix.outputs.versions) }}
+        node-version: ${{ fromJSON(needs.node_matrix.outputs.versions) }}
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v6
+    - uses: actions/setup-node@v6
       with:
         node-version: ${{ matrix.node-version }}
-    - run: npm install --no-package-lock
+        check-latest: true
+    - uses: SocketDev/action@v1
+      with:
+        mode: firewall-free
+    - run: sfw npm install --no-package-lock
       name: Install dev dependencies
     - run: npm run lint
       name: Run linter

package.json

@@ -6,7 +6,7 @@
     "es7",
     "async"
   ],
-  "version": "2.9.3",
+  "version": "3.0.0",
   "author": "jlipps@gmail.com",
   "license": "Apache-2.0",
   "repository": {
@@ -46,13 +46,17 @@
   "devDependencies": {
     "@appium/eslint-config-appium-ts": "^2.0.5",
     "@appium/tsconfig": "^0.x",
+    "@semantic-release/changelog": "^6.0.1",
+    "@semantic-release/git": "^10.0.1",
     "@types/bluebird": "^3.5.37",
     "@types/lodash": "^4.14.189",
     "@types/node": "^20.4.7",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
+    "conventional-changelog-conventionalcommits": "^9.0.0",
     "eslint": "^9.39.1",
     "mocha": "^10.0.0",
+    "semantic-release": "^25.0.2",
     "sinon": "^16.0.0",
     "ts-node": "^10.9.1",
     "typescript": "^5.1.6"

test/asyncbox-specs.js

@@ -86,6 +86,11 @@ describe('retry', function () {
     }
     return times * times;
   };
+  beforeEach(function () {
+    okFnCalls = 0;
+    badFnCalls = 0;
+    eventuallyOkFnCalls = 0;
+  });
   it('should return the result of a passing function', async function () {
     let start = Date.now();
     let res = await retry(3, okFn, 5, 4);
@@ -104,7 +109,7 @@ describe('retry', function () {
     should.exist(err);
     err.message.should.equal('bad');
     badFnCalls.should.equal(3);
-    (Date.now() - start).should.be.above(44);
+    (Date.now() - start).should.be.least(44);
   });
   it('should return the correct value with a function that eventually passes', async function () {
     let err = null;
@@ -140,7 +145,7 @@ describe('retry', function () {
       should.exist(err);
       err.message.should.equal('not ok yet');
       eventuallyOkFnCalls.should.equal(3);
-      (Date.now() - start).should.be.above(30);
+      (Date.now() - start).should.be.least(30);
 
       // rerun with ok number of calls
       start = Date.now();