fix(lsp/java/actions): Handle no fields found and dismiss on action

This commit addresses two issues in the Java LSP actions:

1. **Handles the case where no fields are found:** Previously, actions like generating constructors, getters/setters, or `toString` methods would throw an exception if no fields were found in the class at the specified range. This commit modifies the `findFields` method to return `null` if no fields are found and the respective generator actions now check for this `null` value. If `null` is returned, an error message is displayed to the user.

2. **Dismisses actions on completion:** The `CommentAction` and `UncommentAction` now dismiss the action dialog upon successful execution by overriding `dismissOnAction` to return `true`. This provides a more streamlined user experience.

Author: jatezzz

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/FieldBasedAction.kt

@@ -18,6 +18,7 @@
 package com.itsaky.androidide.lsp.java.actions
 
 import android.content.Context
+import com.blankj.utilcode.util.ThreadUtils
 import com.itsaky.androidide.actions.ActionData
 import com.itsaky.androidide.actions.hasRequiredData
 import com.itsaky.androidide.actions.markInvisible
@@ -28,6 +29,7 @@ import com.itsaky.androidide.lsp.java.compiler.CompileTask
 import com.itsaky.androidide.lsp.java.visitors.FindTypeDeclarationAt
 import com.itsaky.androidide.projects.IProjectManager
 import com.itsaky.androidide.resources.R
+import com.itsaky.androidide.utils.flashError
 import com.itsaky.androidide.utils.flashInfo
 import io.github.rosemoe.sora.widget.CodeEditor
 import jdkx.lang.model.element.Modifier.STATIC
@@ -77,21 +79,21 @@ abstract class FieldBasedAction : BaseJavaCodeAction() {
 
     return JavaCompilerProvider.get(module).compile(file).get { task ->
       val triple = findFields(task, file, range)
-      val type = triple.second
-      val fields = triple.third
-      val fieldNames = fields.map { "${it.name}: ${it.type}" } // Get the names
+      val type = triple?.second
+      val fields = triple?.third
+      val fieldNames = fields?.map { "${it.name}: ${it.type}" } // Get the names
 
-      log.debug("Found {} fields in class {}", fieldNames.size, type.simpleName)
+      log.debug("Found {} fields in class {}", fieldNames?.size, type?.simpleName)
 
-      return@get fieldNames
+      return@get fieldNames ?: emptyList<String>()
     }
   }
 
   protected fun findFields(
     task: CompileTask,
     file: Path,
     range: com.itsaky.androidide.models.Range
-  ): Triple<FindTypeDeclarationAt, ClassTree, MutableList<VariableTree>> {
+  ): Triple<FindTypeDeclarationAt, ClassTree, MutableList<VariableTree>>? {
     // 1-based line and column index
     val startLine = range.start.line + 1
     val startColumn = range.start.column + 1
@@ -114,9 +116,7 @@ abstract class FieldBasedAction : BaseJavaCodeAction() {
     }
 
     if (type == null) {
-      throw CompletionException(
-        RuntimeException("Unable to find class declaration within cursor range")
-      )
+      return null
     }
 
     val fields =
@@ -128,6 +128,25 @@ abstract class FieldBasedAction : BaseJavaCodeAction() {
     return Triple(typeFinder, type, fields)
   }
 
+  protected inline fun withValidFields(
+    data: ActionData,
+    task: CompileTask,
+    file: Path,
+    range: com.itsaky.androidide.models.Range,
+    onValid: (FindTypeDeclarationAt, ClassTree, MutableList<VariableTree>) -> Unit
+  ) {
+    val triple = findFields(task, file, range)
+    if (triple == null) {
+      ThreadUtils.runOnUiThread {
+        flashError(data[Context::class.java]!!.getString(R.string.msg_no_fields_found))
+      }
+      return
+    }
+
+    val (typeFinder, type, fields) = triple
+    onValid(typeFinder, type, fields)
+  }
+
   @Suppress("UNCHECKED_CAST")
   override fun postExec(data: ActionData, result: Any) {
     if (result !is List<*>) {

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/common/CommentAction.kt

@@ -44,5 +44,5 @@ class CommentAction : BaseJavaCodeAction() {
     return true
   }
 
-  override fun dismissOnAction() = false
+  override fun dismissOnAction() = true
 }

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/common/UncommentAction.kt

@@ -48,5 +48,5 @@ class UncommentAction : BaseJavaCodeAction() {
     return true
   }
 
-  override fun dismissOnAction() = false
+  override fun dismissOnAction() = true
 }

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateConstructorAction.kt

@@ -87,16 +87,10 @@ class GenerateConstructorAction : FieldBasedAction() {
     val file = data.requirePath()
 
     compiler.compile(file).run { task ->
-      val triple = findFields(task, file, range)
-      val typeFinder = triple.first
-      val type = triple.second
-      val fields = triple.third
-
-      fields.removeIf { !selected.contains("${it.name}: ${it.type}") }
-
-      log.debug("Creating toString() method with fields: {}", fields.map { it.name })
-
-      generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      withValidFields(data, task, file, range) { typeFinder, type, fields ->
+        fields.removeIf { !selected.contains("${it.name}: ${it.type}") }
+        generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      }
     }
   }
 

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateSettersAndGettersAction.kt

@@ -94,16 +94,10 @@ class GenerateSettersAndGettersAction : FieldBasedAction() {
     val file = data.requirePath()
 
     compiler.compile(file).run { task ->
-      val triple = findFields(task, file, range)
-      val typeFinder = triple.first
-      val type = triple.second
-      val fields = triple.third
-
-      fields.removeIf { !names.contains("${it.name}: ${it.type}") }
-
-      log.debug("Creating setters/getters for fields: {}", fields.map { it.name })
-
-      generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      withValidFields(data, task, file, range) { typeFinder, type, fields ->
+        fields.removeIf { !names.contains("${it.name}: ${it.type}") }
+        generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      }
     }
   }
 

lsp/java/src/main/java/com/itsaky/androidide/lsp/java/actions/generators/GenerateToStringMethodAction.kt

@@ -27,6 +27,7 @@ import com.itsaky.androidide.actions.requireFile
 import com.itsaky.androidide.actions.requirePath
 import com.itsaky.androidide.lsp.java.JavaCompilerProvider
 import com.itsaky.androidide.lsp.java.actions.FieldBasedAction
+import com.itsaky.androidide.lsp.java.actions.generators.GenerateConstructorAction.Companion
 import com.itsaky.androidide.lsp.java.compiler.CompileTask
 import com.itsaky.androidide.lsp.java.utils.EditHelper
 import com.itsaky.androidide.preferences.internal.EditorPreferences
@@ -89,16 +90,10 @@ class GenerateToStringMethodAction : FieldBasedAction() {
     val file = data.requirePath()
 
     compiler.compile(file).run { task ->
-      val triple = findFields(task, file, range)
-      val typeFinder = triple.first
-      val type = triple.second
-      val fields = triple.third
-
-      fields.removeIf { !selected.contains("${it.name}: ${it.type}") }
-
-      log.debug("Creating toString() method with fields: {}", fields.map { it.name })
-
-      generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      withValidFields(data, task, file, range) { typeFinder, type, fields ->
+        fields.removeIf { !selected.contains("${it.name}: ${it.type}") }
+        generateForFields(data, task, type, fields.map { TreePath(typeFinder.path, it) })
+      }
     }
   }