Skip to content

Commit 648c445

Browse files
committed
fixes
1 parent 6ab23b7 commit 648c445

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

plugin-api/src/main/kotlin/com/itsaky/androidide/plugins/extensions/BuildActionExtension.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ object ToolbarActionIds {
3131
FIND, FIND_IN_FILE, FIND_IN_PROJECT,
3232
LAUNCH_APP, DISCONNECT_LOG_SENDERS, GENERATE_XML
3333
)
34+
35+
val BUILD_HIDEABLE: Set<String> = setOf(
36+
QUICK_RUN, PROJECT_SYNC, DEBUG, RUN_TASKS, LAUNCH_APP
37+
)
3438
}
3539

3640
data class PluginBuildAction(

plugin-manager/src/main/kotlin/com/itsaky/androidide/plugins/manager/build/PluginBuildActionManager.kt

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,22 @@ class PluginBuildActionManager private constructor() {
7373
fun getHiddenActionIds(): Set<String> {
7474
val hidden = mutableSetOf<String>()
7575

76-
for ((_, extension) in pluginExtensions) {
76+
for ((pluginId, extension) in pluginExtensions) {
7777
runCatching {
7878
val requested = extension.toolbarActionsToHide()
79-
hidden.addAll(requested.intersect(ToolbarActionIds.ALL))
79+
val allowed = requested.intersect(ToolbarActionIds.BUILD_HIDEABLE)
80+
hidden.addAll(allowed)
81+
82+
val rejected = requested - ToolbarActionIds.BUILD_HIDEABLE
83+
if (rejected.isNotEmpty()) {
84+
Log.w(
85+
TAG,
86+
"Plugin $pluginId requested to hide non-build toolbar actions " +
87+
"$rejected; ignored. Only ${ToolbarActionIds.BUILD_HIDEABLE} are hideable."
88+
)
89+
}
8090
}.onFailure { e ->
81-
Log.w(TAG, "Failed to get hidden action ids from plugin", e)
91+
Log.w(TAG, "Failed to get hidden action ids from plugin $pluginId", e)
8292
}
8393
}
8494

0 commit comments

Comments
 (0)