fix(editor): resolve PR feedback for bottom sheet anchor, state binding, and redundant LiveData

Author: jatezzz

app/src/main/java/com/itsaky/androidide/activities/editor/FullscreenManager.kt

@@ -130,26 +130,28 @@ class FullscreenManager(
 
     fun bind() {
         if (isBound) return
-        isBound = true
 
         defaultSkipCollapsed = bottomSheetBehavior.skipCollapsed
         bottomSheetBehavior.skipCollapsed = false
         setupScrollFlags()
         topBar.addOnOffsetChangedListener(offsetListener)
         bottomSheetBehavior.addBottomSheetCallback(bottomSheetCallback)
         fullscreenToggle.setOnClickListener { onFullscreenToggleRequested() }
+
+        isBound = true
     }
 
     fun destroy() {
         if (!isBound) return
-        isBound = false
 
         fullscreenToggle.setOnClickListener(null)
         topBar.removeOnOffsetChangedListener(offsetListener)
         bottomSheetBehavior.removeBottomSheetCallback(bottomSheetCallback)
         bottomSheetBehavior.skipCollapsed = defaultSkipCollapsed
         fullscreenToggle.removeCallbacks(clearTransitioningRunnable)
         isTransitioning = false
+
+        isBound = false
     }
 
     fun render(isFullscreen: Boolean, animate: Boolean) {

app/src/main/java/com/itsaky/androidide/utils/WindowInsetsExtensions.kt

@@ -107,8 +107,15 @@ fun ContentEditorBinding.applyImmersiveModeInsets(systemBars: Insets) {
 }
 
 /**
- * Allows the bottom sheet to expand fully while relying on top insets to stay clear of system bars.
+ * Anchors the bottom sheet below the app bar in portrait, but allows it to expand
+ * fully in landscape to save vertical screen real estate.
  */
 fun ContentEditorBinding.applyBottomSheetAnchorForOrientation(orientation: Int) {
-    bottomSheet.resetOffsetAnchor()
+    root.post {
+        if (orientation == Configuration.ORIENTATION_LANDSCAPE) {
+            bottomSheet.resetOffsetAnchor()
+        } else {
+            bottomSheet.setOffsetAnchor(editorAppBarLayout)
+        }
+    }
 }

app/src/main/java/com/itsaky/androidide/viewmodel/EditorViewModel.kt

@@ -59,7 +59,6 @@ class EditorViewModel : ViewModel() {
 
     internal val _filesModified = MutableLiveData(false)
     internal val _filesSaving = MutableLiveData(false)
-    internal val _isFullscreen = MutableLiveData(false)
 
     private val _openedFiles = MutableLiveData<OpenedFilesCache>()
     private val _isBoundToBuildService = MutableLiveData(false)
@@ -160,7 +159,6 @@ class EditorViewModel : ViewModel() {
                 current.copy(isFullscreen = value)
             }
         }
-        _isFullscreen.value = value
     }
 
     fun toggleFullscreen() {