ADFA-3235 | Fix checkbox selection bug in project list (#1075)

* fix: replace OnCheckedChangeListener with OnClickListener
Prevents unintended selection state changes during RecyclerView scrolling.

* refactor: migrate DeleteProjectListAdapter to Checkable<ProjectFile> selection model
improve UX by toggling selection from item click and removing internal selection state

Author: jatezzz

app/src/main/java/com/itsaky/androidide/adapters/DeleteProjectListAdapter.kt

@@ -4,19 +4,16 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.recyclerview.widget.RecyclerView
-import com.itsaky.androidide.R
 import com.itsaky.androidide.databinding.DeleteProjectsItemBinding
-import com.itsaky.androidide.utils.formatDate
+import com.itsaky.androidide.models.Checkable
 import org.appdevforall.codeonthego.layouteditor.ProjectFile
 
 class DeleteProjectListAdapter(
-    private var projects: List<ProjectFile>,
+    private var projects: List<Checkable<ProjectFile>>,
     private val onSelectionChange: (Boolean) -> Unit,
     private val onCheckboxLongPress: () -> Boolean
 ) : RecyclerView.Adapter<DeleteProjectListAdapter.ProjectViewHolder>() {
 
-    private val selectedProjects = mutableSetOf<ProjectFile>()
-
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ProjectViewHolder {
         val binding =
             DeleteProjectsItemBinding.inflate(LayoutInflater.from(parent.context), parent, false)
@@ -29,33 +26,40 @@ class DeleteProjectListAdapter(
 
     override fun getItemCount(): Int = projects.size
 
-    fun getSelectedProjects(): List<ProjectFile> = selectedProjects.toList()
+    fun getSelectedProjects(): List<ProjectFile> = projects.filter { it.isChecked }.map { it.data }
 
-    fun updateProjects(newProjects: List<ProjectFile>) {
+    fun updateProjects(newProjects: List<Checkable<ProjectFile>>) {
         projects = newProjects
         notifyDataSetChanged()
     }
 
-    fun renderDate(binding: DeleteProjectsItemBinding, project: ProjectFile) {
+    private fun hasSelection(): Boolean = projects.any { it.isChecked }
+
+    private fun renderDate(binding: DeleteProjectsItemBinding, project: ProjectFile) {
         binding.projectDate.text = project.renderDateText(binding.root.context)
     }
 
     inner class ProjectViewHolder(private val binding: DeleteProjectsItemBinding) :
         RecyclerView.ViewHolder(binding.root) {
 
-        fun bind(project: ProjectFile) {
+        fun bind(item: Checkable<ProjectFile>) {
+            val project = item.data
+
             binding.projectName.text = project.name
             renderDate(binding, project)
             binding.icon.text = project.name.take(2).uppercase()
 
             binding.checkbox.visibility = View.VISIBLE
-            binding.checkbox.isChecked = selectedProjects.contains(project)
+            binding.checkbox.isChecked = item.isChecked
+
+            binding.root.setOnClickListener {
+                item.isChecked = !item.isChecked
+                binding.checkbox.isChecked = item.isChecked
+                onSelectionChange(hasSelection())
+            }
 
-            binding.checkbox.setOnCheckedChangeListener { _, isChecked ->
-                if (isChecked) selectedProjects.add(project) else selectedProjects.remove(
-                    project
-                )
-                onSelectionChange(selectedProjects.isNotEmpty())
+            binding.checkbox.setOnClickListener {
+                binding.root.performClick()
             }
 
             binding.checkbox.setOnLongClickListener {

app/src/main/java/com/itsaky/androidide/fragments/DeleteProjectFragment.kt

@@ -20,6 +20,7 @@ import com.itsaky.androidide.idetooltips.TooltipTag.DELETE_PROJECT_DIALOG
 import com.itsaky.androidide.idetooltips.TooltipTag.DELETE_PROJECT_SELECT
 import com.itsaky.androidide.idetooltips.TooltipTag.EXIT_TO_MAIN
 import com.itsaky.androidide.idetooltips.TooltipTag.PROJECT_NEW
+import com.itsaky.androidide.models.Checkable
 import com.itsaky.androidide.ui.CustomDividerItemDecoration
 import com.itsaky.androidide.utils.flashError
 import com.itsaky.androidide.utils.flashSuccess
@@ -61,23 +62,34 @@ class DeleteProjectFragment : BaseFragment() {
 
     private fun observeProjects() {
         recentProjectsViewModel.projects.observe(viewLifecycleOwner) { projects ->
+            val selectedPaths = adapter
+                ?.getSelectedProjects()
+                ?.map { it.path }
+                ?.toSet()
+                .orEmpty()
+
+            val checkableProjects = projects.map { project ->
+                Checkable(project.path in selectedPaths, project)
+            }
+
             if (adapter == null) {
                 // Create adapter and pass a callback to update delete button state on selection change
                 adapter = DeleteProjectListAdapter(
-                    projects,
+                    checkableProjects,
                     { enableBtn ->
                         updateDeleteButtonState(enableBtn)
                     },
                     onCheckboxLongPress = {
-                        showToolTip(DELETE_PROJECT_SELECT)
+                        showToolTip(DELETE_PROJECT_SELECT, binding.listProjects)
                         true
                     }
 
                 )
                 binding.listProjects.adapter = adapter
             } else {
-                adapter?.updateProjects(projects)
+                adapter?.updateProjects(checkableProjects)
             }
+
             binding.recentProjectsTxt.isVisible = projects.isNotEmpty()
             binding.noProjectsView.isVisible = projects.isEmpty()
 
@@ -87,7 +99,7 @@ class DeleteProjectFragment : BaseFragment() {
                 binding.delete.isEnabled = true
             } else {
                 binding.delete.text = getString(R.string.delete_project)
-                updateDeleteButtonState(adapter?.getSelectedProjects()?.isNotEmpty() ?: false)
+                updateDeleteButtonState(adapter?.getSelectedProjects()?.isNotEmpty() == true)
             }
         }
     }