Merge pull request #276 from appcelerator/APIGOV-32125

Engage CLI - Migrate & Refactor Results Rendering Functionality

Author: kasuvy

package-lock.json

@@ -34,6 +34,7 @@
     "cli-table3": "^0.6.5",
     "dayjs": "^1.11.19",
     "debug": "^4.4.3",
+    "easy-table": "^1.2.0",
     "fastest-levenshtein": "^1.0.16",
     "got": "^14.6.2",
     "http-proxy-agent": "^7.0.2",

package.json

@@ -126,7 +126,7 @@ class CacheControllerClass implements Cache {
           < CACHE_FILE_TTL_MILLISECONDS
 			) {
 				for (const [ key, val ] of Object.entries(storedCache.data)) {
-					if (storedCache.data.hasOwnProperty(key)) {
+					if (Object.prototype.hasOwnProperty.call(storedCache.data, key)) {
 						this.cache.set(key, val);
 					}
 				}
@@ -138,9 +138,8 @@ class CacheControllerClass implements Cache {
 			}
 		} catch (e) {
 			log('cannot read cache from the file', e);
-		} finally {
-			return this;
 		}
+		return this;
 	}
 
 	/**
@@ -169,9 +168,8 @@ class CacheControllerClass implements Cache {
 			writeToFile(this.cacheFilePath, JSON.stringify(dataToStore));
 		} catch (e) {
 			log('cannot write cache to the file', e);
-		} finally {
-			return this;
 		}
+		return this;
 	}
 }