-
Notifications
You must be signed in to change notification settings - Fork 164
Use ws instead of faye-websocket for websocket tests #621
Copy link
Copy link
Open
Labels
debtCode quality improvement or decrease of technical debt.Code quality improvement or decrease of technical debt.low priorityLow priority issues to be done eventually.Low priority issues to be done eventually.t-unblockingIssues with this label are in the ownership of the unblocking team.Issues with this label are in the ownership of the unblocking team.
Metadata
Metadata
Assignees
Labels
debtCode quality improvement or decrease of technical debt.Code quality improvement or decrease of technical debt.low priorityLow priority issues to be done eventually.Low priority issues to be done eventually.t-unblockingIssues with this label are in the ownership of the unblocking team.Issues with this label are in the ownership of the unblocking team.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently we have both libraries in our devDependencies. Let's migrate out tests to use
wsfully instead offaye-websocket.Why it makes sense:
wsis de-facto a standard websocket library for Nodewshas better maintainability (faye-websocketgot last commit 2 years ago)wshas betterwsssupport, because of it it's already imported intest/tls_overhead_stats.js