Pass router as request_handler to crawler - is this intended?

[vdusek]

For example:

from crawlee.crawlers import PlaywrightCrawler
from crawlee.router import Router

router = Router[PlaywrightCrawlingContext]()

# ...

crawler = PlaywrightCrawler(
    request_handler=router,
)

Shouldn't the arg be named router?

We would also need to update its type and this part of the BasicCrawler's init:

# Request router setup
self._router: Router[TCrawlingContext] | None = None
if isinstance(cast('Router', request_handler), Router):
    self._router = cast('Router[TCrawlingContext]', request_handler)
elif request_handler is not None:
    self._router = None
    self.router.default_handler(request_handler)

[janbuchar]

It is intended, but it can be re-evaluated for sure. Originally I wanted to be as permissive as possible and accept even simple callables in the request_handler.

[vdusek]

I understand, and we can keep the current behavior if it makes sense. But I believe the name should reflect the most common use case, which is registering a router. Registering a single handler can be done without passing it as an argument, and throughout our documentation, we consistently use the default router's request-handler decorator for that purpose. So I believe most people will do just that.