clang fixes

Author: serrislew

src/proxy/http/remap/RemapYamlConfig.cc

@@ -197,8 +197,6 @@ remap_validate_yaml_filter_args(acl_filter_rule **rule_pp, const YAML::Node &nod
     return swoc::Errata("filters must be a map");
   }
 
-  bool action_flag = false;
-
   // Parse method
   auto parse_method = [&](const std::string &method_str) {
     int m = hdrtoken_tokenize(method_str.c_str(), method_str.length(), nullptr) - HTTP_WKSIDX_CONNECT;
@@ -408,15 +406,6 @@ remap_validate_yaml_filter_args(acl_filter_rule **rule_pp, const YAML::Node &nod
 
   // Parse action
   if (node["action"]) {
-    if (action_flag) {
-      Dbg(dbg_ctl_url_rewrite, "Only one action: is allowed per remap ACL");
-      if (new_rule_flg) {
-        delete rule;
-        *rule_pp = nullptr;
-      }
-      return swoc::Errata("Only one action is allowed per remap ACL");
-    }
-    action_flag            = true;
     std::string action_str = node["action"].as<std::string>();
     if (behavior_policy == ACLBehaviorPolicy::ACL_BEHAVIOR_MODERN) {
       // With the new matching policy, we don't allow the legacy "allow" and
@@ -652,9 +641,9 @@ parse_yaml_define_directive(const YAML::Node &node, BUILD_TABLE_INFO *bti)
 
   // When iterating over a YAML map, each element is a key-value pair
   // We expect a single-entry map here
-  auto              it          = node.begin();
-  std::string       filter_name = it->first.as<std::string>();
-  const YAML::Node &filter_spec = it->second;
+  auto             it          = node.begin();
+  std::string      filter_name = it->first.as<std::string>();
+  const YAML::Node filter_spec = it->second;
 
   flg = ((rp = acl_filter_rule::find_byname(bti->rules_list, filter_name.c_str())) == nullptr) ? true : false;
   // coverity[alloc_arg]
@@ -1030,7 +1019,8 @@ parse_yaml_remap_rule(const YAML::Node &node, BUILD_TABLE_INFO *bti)
   if (node["plugins"] && (maptype == mapping_type::FORWARD_MAP || maptype == mapping_type::FORWARD_MAP_REFERER ||
                           maptype == mapping_type::FORWARD_MAP_WITH_RECV_PORT)) {
     if (!node["plugins"] || !node["plugins"].IsSequence()) {
-      return swoc::Errata("plugins must be a sequence");
+      errStr = "plugins must be a sequence";
+      goto MAP_ERROR;
     }
 
     for (const auto &plugin : node["plugins"]) {
@@ -1048,7 +1038,7 @@ parse_yaml_remap_rule(const YAML::Node &node, BUILD_TABLE_INFO *bti)
     goto MAP_ERROR;
   }
 
-  fromHost_lower_ptr = static_cast<char *>(ats_free_null(fromHost_lower_ptr));
+  ats_free_null(fromHost_lower_ptr);
 
   Dbg(dbg_ctl_remap_yaml, "Successfully added mapping rule");
   return {};