Skip to content

Commit 2dcfda5

Browse files
authored
Fix crash during raw connect failures (#8306)
In the case of raw open, the server_txn will generally be a nullptr. We tried to use server_txn when calling set_connect_fail, which resulted in a crash. This change simply removes the call. Note that a generic call to set_connect_fail was already called previous to calling this function.
1 parent e1ef04d commit 2dcfda5

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

proxy/http/HttpSM.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,6 @@ HttpSM::state_raw_http_server_open(int event, void *data)
12521252

12531253
case VC_EVENT_ERROR:
12541254
case NET_EVENT_OPEN_FAILED:
1255-
t_state.set_connect_fail(server_txn->get_netvc()->lerrno);
12561255
t_state.current.state = HttpTransact::OPEN_RAW_ERROR;
12571256
// use this value just to get around other values
12581257
t_state.hdr_info.response_error = HttpTransact::STATUS_CODE_SERVER_ERROR;

0 commit comments

Comments
 (0)