Fix MongoDB 4.x plugin to support driver 4.9+ (db.bind_vars extraction)

MongoDB driver 4.9 removed InsertOperation, DeleteOperation, UpdateOperation
classes. MongoOperationHelper imported them, causing NoClassDefFoundError at
class load time which silently broke all db.bind_vars extraction.

Fix: use Class.forName check to detect legacy classes at startup, isolate
legacy imports into LegacyOperationHelper (only loaded when classes exist).
For 4.9+, all write operations go through MixedBulkWriteOperation which
the plugin already handles via getWriteRequests().

Author: wu-sheng

CHANGES.md

@@ -11,7 +11,7 @@ Release Notes.
 * Add Spring RabbitMQ 2.x - 4.x plugin.
 * Extend MySQL plugin to support MySQL Connector/J 8.4.0 and 9.x (9.0 -> 9.6).
 * Extend MariaDB plugin to support MariaDB Connector/J 2.7.x.
-* Extend MongoDB 4.x plugin to support MongoDB Java Driver 4.2 -> 4.10.
+* Extend MongoDB 4.x plugin to support MongoDB Java Driver 4.2 -> 4.10. Fix db.bind_vars extraction for driver 4.9+ where InsertOperation/DeleteOperation/UpdateOperation classes were removed.
 * Extend Feign plugin to support OpenFeign 10.x, 11.x, 12.1.
 * Extend Undertow plugin to support Undertow 2.1.x, 2.2.x, 2.3.x.
 * Extend GraphQL plugin to support graphql-java 18 -> 24 (20+ requires JDK 17).

apm-sniffer/apm-sdk-plugin/mongodb-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/LegacyOperationHelper.java

@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.mongodb.v4.support;
+
+import com.mongodb.internal.bulk.DeleteRequest;
+import com.mongodb.internal.bulk.InsertRequest;
+import com.mongodb.internal.bulk.UpdateRequest;
+import com.mongodb.internal.operation.DeleteOperation;
+import com.mongodb.internal.operation.InsertOperation;
+import com.mongodb.internal.operation.UpdateOperation;
+
+import java.util.List;
+
+/**
+ * Handles trace parameter extraction for legacy MongoDB driver versions (4.0 - 4.8).
+ * InsertOperation, DeleteOperation, and UpdateOperation were removed in driver 4.9.
+ * This class is only loaded when those classes exist (guarded by
+ * {@link MongoOperationHelper#HAS_LEGACY_WRITE_OPERATIONS}).
+ */
+@SuppressWarnings("deprecation")
+class LegacyOperationHelper {
+
+    private LegacyOperationHelper() {
+    }
+
+    /**
+     * Extract trace parameters from legacy write operation types.
+     * @return the trace parameter string, or null if obj is not a legacy write operation
+     */
+    static String getTraceParam(Object obj) {
+        if (obj instanceof DeleteOperation) {
+            List<DeleteRequest> writeRequestList = ((DeleteOperation) obj).getDeleteRequests();
+            return MongoOperationHelper.getFilter(writeRequestList);
+        } else if (obj instanceof InsertOperation) {
+            List<InsertRequest> writeRequestList = ((InsertOperation) obj).getInsertRequests();
+            return MongoOperationHelper.getFilter(writeRequestList);
+        } else if (obj instanceof UpdateOperation) {
+            List<UpdateRequest> writeRequestList = ((UpdateOperation) obj).getUpdateRequests();
+            return MongoOperationHelper.getFilter(writeRequestList);
+        }
+        return null;
+    }
+}

apm-sniffer/apm-sdk-plugin/mongodb-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/MongoOperationHelper.java

@@ -27,18 +27,15 @@
 import com.mongodb.internal.operation.CreateCollectionOperation;
 import com.mongodb.internal.operation.CreateIndexesOperation;
 import com.mongodb.internal.operation.CreateViewOperation;
-import com.mongodb.internal.operation.DeleteOperation;
 import com.mongodb.internal.operation.DistinctOperation;
 import com.mongodb.internal.operation.FindAndDeleteOperation;
 import com.mongodb.internal.operation.FindAndReplaceOperation;
 import com.mongodb.internal.operation.FindAndUpdateOperation;
 import com.mongodb.internal.operation.FindOperation;
-import com.mongodb.internal.operation.InsertOperation;
 import com.mongodb.internal.operation.ListCollectionsOperation;
 import com.mongodb.internal.operation.MapReduceToCollectionOperation;
 import com.mongodb.internal.operation.MapReduceWithInlineResultsOperation;
 import com.mongodb.internal.operation.MixedBulkWriteOperation;
-import com.mongodb.internal.operation.UpdateOperation;
 import org.bson.BsonDocument;
 
 import java.util.List;
@@ -49,6 +46,21 @@
 })
 public class MongoOperationHelper {
 
+    // InsertOperation, DeleteOperation, UpdateOperation were removed in MongoDB driver 4.9.
+    // Use class existence check to determine which extraction path to use.
+    private static final boolean HAS_LEGACY_WRITE_OPERATIONS;
+
+    static {
+        boolean hasLegacy;
+        try {
+            Class.forName("com.mongodb.internal.operation.InsertOperation");
+            hasLegacy = true;
+        } catch (ClassNotFoundException e) {
+            hasLegacy = false;
+        }
+        HAS_LEGACY_WRITE_OPERATIONS = hasLegacy;
+    }
+
     private MongoOperationHelper() {
 
     }
@@ -69,22 +81,25 @@ public static String getTraceParam(Object obj) {
         } else if (obj instanceof FindOperation) {
             BsonDocument filter = ((FindOperation) obj).getFilter();
             return limitFilter(filter.toString());
-        }  else if (obj instanceof ListCollectionsOperation) {
+        } else if (obj instanceof ListCollectionsOperation) {
             BsonDocument filter = ((ListCollectionsOperation) obj).getFilter();
             return limitFilter(filter.toString());
         } else if (obj instanceof MapReduceWithInlineResultsOperation) {
             BsonDocument filter = ((MapReduceWithInlineResultsOperation) obj).getFilter();
             return limitFilter(filter.toString());
-        } else if (obj instanceof DeleteOperation) {
-            List<DeleteRequest> writeRequestList = ((DeleteOperation) obj).getDeleteRequests();
-            return getFilter(writeRequestList);
-        } else if (obj instanceof InsertOperation) {
-            List<InsertRequest> writeRequestList = ((InsertOperation) obj).getInsertRequests();
-            return getFilter(writeRequestList);
-        } else if (obj instanceof UpdateOperation) {
-            List<UpdateRequest> writeRequestList = ((UpdateOperation) obj).getUpdateRequests();
-            return getFilter(writeRequestList);
-        } else if (obj instanceof CreateCollectionOperation) {
+        } else if (HAS_LEGACY_WRITE_OPERATIONS) {
+            String result = LegacyOperationHelper.getTraceParam(obj);
+            if (result != null) {
+                return result;
+            }
+            return getCommonTraceParam(obj);
+        } else {
+            return getCommonTraceParam(obj);
+        }
+    }
+
+    private static String getCommonTraceParam(Object obj) {
+        if (obj instanceof CreateCollectionOperation) {
             String filter = ((CreateCollectionOperation) obj).getCollectionName();
             return limitFilter(filter);
         } else if (obj instanceof CreateIndexesOperation) {
@@ -128,7 +143,7 @@ private static String getPipelines(List<BsonDocument> pipelines) {
         return params.toString();
     }
 
-    private static String getFilter(List<? extends WriteRequest> writeRequestList) {
+    static String getFilter(List<? extends WriteRequest> writeRequestList) {
         StringBuilder params = new StringBuilder();
         for (WriteRequest request : writeRequestList) {
             if (request instanceof InsertRequest) {

test/plugin/scenarios/mongodb-4.x-scenario/support-version.list

@@ -23,6 +23,5 @@
 4.6.1
 4.7.2
 4.8.2
-# 4.9+ removed InsertOperation, DeleteOperation, UpdateOperation classes.
-# MongoOperationHelper imports them causing NoClassDefFoundError at load time,
-# which breaks db.bind_vars extraction. Needs a new mongodb-4.9.x-plugin module.
+4.9.1
+4.10.2