Fixed format. Added depreciated comment. Passed StickRanges as reference. Implicit conversion from std::initializer_list to std::vector

Author: hyperevo

.gitignore

@@ -69,6 +69,7 @@ include/pulsar/Version.h
 *.ninja*
 .clangd/
 compile_commands.json
+.cmake-build-debug/
 
 # doxygen files
 apidocs/

examples/SampleCustomLoggerCApi

@@ -95,14 +95,14 @@ class PULSAR_PUBLIC KeySharedPolicy {
 
     /**
      * @param ranges used with sticky mode
+     * @deprecated use the function that takes StickyRanges instead of std::initializer_list
      */
     KeySharedPolicy& setStickyRanges(std::initializer_list<StickyRange> ranges);
 
     /**
      * @param ranges used with sticky mode
      */
-    KeySharedPolicy& setStickyRanges(StickyRanges ranges);
-
+    KeySharedPolicy& setStickyRanges(const StickyRanges& ranges);
 
     /**
      * @return ranges used with sticky mode

include/pulsar/KeySharedPolicy.h

@@ -51,15 +51,10 @@ KeySharedPolicy &KeySharedPolicy::setAllowOutOfOrderDelivery(bool allowOutOfOrde
 bool KeySharedPolicy::isAllowOutOfOrderDelivery() const { return impl_->allowOutOfOrderDelivery; }
 
 KeySharedPolicy &KeySharedPolicy::setStickyRanges(std::initializer_list<StickyRange> ranges) {
-    StickyRanges v;
-    for(StickyRange i:ranges)
-    {
-        v.push_back(i);
-    }
-    return this->setStickyRanges(v);
+    return this->setStickyRanges(StickyRanges v(ranges));
 }
 
-KeySharedPolicy &KeySharedPolicy::setStickyRanges(StickyRanges ranges) {
+KeySharedPolicy &KeySharedPolicy::setStickyRanges(const StickyRanges &ranges) {
     if (ranges.empty()) {
         throw std::invalid_argument("Ranges for KeyShared policy must not be empty.");
     }

lib/KeySharedPolicy.cc

@@ -207,8 +207,8 @@ TEST_F(KeySharedPolicyTest, testStickyConsumerExpected) {
     KeySharedPolicy ksp;
     ksp.setStickyRanges({StickyRange(0, 300), StickyRange(400, 500)});
 
-    std::vector<std::pair<int, int>> expectedStickyRange {{0, 300}, {400, 500}};
-    ASSERT_EQ(ksp.getStickyRanges(),expectedStickyRange);
+    std::vector<std::pair<int, int>> expectedStickyRange{{0, 300}, {400, 500}};
+    ASSERT_EQ(ksp.getStickyRanges(), expectedStickyRange);
 }
 
 TEST_F(KeySharedPolicyTest, testStickyConsumerVectors) {
@@ -217,9 +217,8 @@ TEST_F(KeySharedPolicyTest, testStickyConsumerVectors) {
     ksp.setStickyRanges({StickyRange(0, 300), StickyRange(400, 500)});
 
     KeySharedPolicy ksp2;
-    std::vector<std::pair<int, int>> stickyRangeVec {{0, 300}, {400, 500}};
+    std::vector<std::pair<int, int>> stickyRangeVec{{0, 300}, {400, 500}};
     ksp2.setStickyRanges(stickyRangeVec);
 
     ASSERT_EQ(ksp.getStickyRanges(), ksp2.getStickyRanges());
-
 }