diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java index 190c542809ff..561d3e1b2447 100644 --- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java +++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java @@ -81,6 +81,7 @@ import org.apache.hadoop.hdds.tracing.TracingUtil; import org.apache.hadoop.hdds.utils.HddsServerUtil; import org.apache.hadoop.hdds.utils.HddsVersionInfo; +import org.apache.hadoop.hdds.utils.IOUtils; import org.apache.hadoop.metrics2.util.MBeans; import org.apache.hadoop.ozone.container.common.DatanodeLayoutStorage; import org.apache.hadoop.ozone.container.common.helpers.ContainerUtils; @@ -579,6 +580,7 @@ public void stop() { } } } + IOUtils.close(LOG, reconfigurationHandler); if (datanodeStateMachine != null) { datanodeStateMachine.stopDaemon(); } diff --git a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/ReconfigurationHandler.java b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/ReconfigurationHandler.java index 32eb67c0797f..1277e1eef3cf 100644 --- a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/ReconfigurationHandler.java +++ b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/ReconfigurationHandler.java @@ -186,9 +186,7 @@ public ReconfigurationTaskStatus getReconfigureStatus() throws IOException { @Override public List listReconfigureProperties() throws IOException { requireAdminPrivilege.accept("listReconfigurableProperties"); - Set reconfigureProperties = new TreeSet<>(getReconfigurableProperties()); - reconfigureProperties.addAll(prefixProperties); - return new ArrayList<>(reconfigureProperties); + return new ArrayList<>(new TreeSet<>(getReconfigurableProperties())); } @Override diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java index 32673e87279b..133eafe45b73 100644 --- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java +++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java @@ -1644,7 +1644,7 @@ private void persistSCMCertificates() throws IOException { public void stop() { if (isStopped.getAndSet(true)) { LOG.info("Storage Container Manager is not running."); - IOUtils.close(LOG, scmHAManager); + IOUtils.close(LOG, reconfigurationHandler, scmHAManager); stopReplicationManager(); // started eagerly return; } diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java index 070dd6d68b5b..cf10e6643f38 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java @@ -199,6 +199,7 @@ import org.apache.hadoop.hdds.server.http.RatisDropwizardExports; import org.apache.hadoop.hdds.utils.HAUtils; import org.apache.hadoop.hdds.utils.HddsServerUtil; +import org.apache.hadoop.hdds.utils.IOUtils; import org.apache.hadoop.hdds.utils.LegacyHadoopConfigurationSource; import org.apache.hadoop.hdds.utils.ProtocolMessageMetrics; import org.apache.hadoop.hdds.utils.TransactionInfo; @@ -2379,6 +2380,7 @@ public boolean stop() { } try { omState = State.STOPPED; + IOUtils.close(LOG, reconfigurationHandler); // Cancel the metrics timer and set to null. if (metricsTimer != null) { metricsTimer.cancel();