From d019b9c2ea1149ec6ffbe0d56bca0bf25708aa39 Mon Sep 17 00:00:00 2001
From: Vincent Potucek <vpotucek@me.com>
Date: Mon, 9 Jun 2025 22:51:10 +0200
Subject: [PATCH] [S1161] Enable PMD check MissingOverride

---
 .pmd/ruleset.xml | 27 +++++++++++++++++++++++++++
 pom.xml          | 25 ++++++++++++++++++-------
 2 files changed, 45 insertions(+), 7 deletions(-)
 create mode 100644 .pmd/ruleset.xml

diff --git a/.pmd/ruleset.xml b/.pmd/ruleset.xml
new file mode 100644
index 000000000000..64efc827de4c
--- /dev/null
+++ b/.pmd/ruleset.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<ruleset name="Definition of Done"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+    <description>Programmatic approach to maintain code quality on large scale.</description>
+    <exclude-pattern>.*/compat/maven-compat/.*</exclude-pattern>
+    <rule ref="category/java/bestpractices.xml/MissingOverride" />
+</ruleset>
diff --git a/pom.xml b/pom.xml
index c0386c89308d..e6cf486d30cf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -798,13 +798,20 @@ under the License.</licenseText>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-pmd-plugin</artifactId>
-          <dependencies>
-            <dependency>
-              <groupId>net.sourceforge.pmd</groupId>
-              <artifactId>pmd-core</artifactId>
-              <version>7.14.0</version>
-            </dependency>
-          </dependencies>
+          <configuration>
+            <analysisCache>true</analysisCache>
+            <printFailingErrors>true</printFailingErrors>
+            <rulesets>
+              <ruleset>.pmd/ruleset.xml</ruleset>
+            </rulesets>
+          </configuration>
+          <executions>
+            <execution>
+              <goals>
+                <goal>check</goal>
+              </goals>
+            </execution>
+          </executions>
         </plugin>
         <plugin>
           <groupId>org.eclipse.sisu</groupId>
@@ -821,6 +828,10 @@ under the License.</licenseText>
       </plugins>
     </pluginManagement>
     <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-pmd-plugin</artifactId>
+      </plugin>
       <plugin>
         <groupId>io.github.olamy.maven.plugins</groupId>
         <artifactId>jacoco-aggregator-maven-plugin</artifactId>