From 8bf5b0e7e3ccfcb687a7dcf697f005479dd036db Mon Sep 17 00:00:00 2001 From: armorbreak001 Date: Tue, 21 Apr 2026 12:37:40 +0800 Subject: [PATCH] fix(wrapper): trim property keys when parsing maven-wrapper.properties When an IDE or formatter adds spaces around '=' in maven-wrapper.properties (e.g., 'distributionUrl = ...'), the shell parser's IFS='=' split leaves trailing whitespace in the key, causing case pattern matches to fail with 'cannot read distributionUrl property'. Apply trim() to keys in all three property-parsing loops (mvnw: wrapperUrl + wrapperSha256Sum; only-mvnw: distributionUrl + distributionSha256Sum) to tolerate such formatting. Fixes #369 --- maven-wrapper-distribution/src/resources/mvnw | 2 ++ maven-wrapper-distribution/src/resources/only-mvnw | 1 + 2 files changed, 3 insertions(+) diff --git a/maven-wrapper-distribution/src/resources/mvnw b/maven-wrapper-distribution/src/resources/mvnw index df1a80ac..80a02256 100755 --- a/maven-wrapper-distribution/src/resources/mvnw +++ b/maven-wrapper-distribution/src/resources/mvnw @@ -225,6 +225,7 @@ else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar" fi while IFS="=" read -r key value; do + key=$(trim "${key-}") case "$key" in wrapperUrl) wrapperUrl=$(trim "${value-}") break @@ -281,6 +282,7 @@ fi # If specified, validate the SHA-256 sum of the Maven wrapper jar file wrapperSha256Sum="" while IFS="=" read -r key value; do + key=$(trim "${key-}") case "$key" in wrapperSha256Sum) wrapperSha256Sum=$(trim "${value-}") break diff --git a/maven-wrapper-distribution/src/resources/only-mvnw b/maven-wrapper-distribution/src/resources/only-mvnw index 6d8e3f8d..98025cde 100755 --- a/maven-wrapper-distribution/src/resources/only-mvnw +++ b/maven-wrapper-distribution/src/resources/only-mvnw @@ -110,6 +110,7 @@ scriptName="$(basename "$0")" # parse distributionUrl and optional distributionSha256Sum, requires .mvn/wrapper/maven-wrapper.properties while IFS="=" read -r key value; do + key=$(trim "${key-}") case "${key-}" in distributionUrl) distributionUrl=$(trim "${value-}") ;; distributionSha256Sum) distributionSha256Sum=$(trim "${value-}") ;;