shading failure on JDK 24

[jakub-id]

Affected version

3.6.0

Bug description

On JDK 24 with minimizeJar=true shading errors with:

Error creating shaded jar: Unsupported class file major version 68

Bumping ASM dependency to 9.8 does not fix the problem. Please release a new version which support JDK24 and JDK25.

[cstamas]

Creating a small reproducer would be appreciated.

[olamy]

stacktrace I can see

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 68
    at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init> (ClassReader.java:200)
    at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init> (ClassReader.java:180)
    at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init> (ClassReader.java:166)
    at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init> (ClassReader.java:288)
    at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:179)
    at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:151)
    at org.apache.maven.plugins.shade.filter.MinijarFilter.<init> (MinijarFilter.java:104)

We only to use the new release org.vafer:jdependency:2.13

[olamy]

done via #749
haha so groovy has his shaded asm, jdependency has his shaded asm. someone else? :)

[olamy]

arghh right org.vafer:jdependency:2.13 is jdk 11 minimum :(

[olamy]

@jakub-id you can still upgrade the version in your pom in the plugin > dependencies section.

[Gaibhne]

I attempted to work around this in 3.6.0 by forcing the jdependency:2.13 dependency, but that alone was not enough, the update to asm:9.8 was also needed. Only with both forced dependencies I was able to compile with 24. asm-commons:9.8 isn't needed, but it'd probably be a bad idea to have a mismatch there.

[olamy]

I attempted to work around this in 3.6.0 by forcing the jdependency:2.13 dependency, but that alone was not enough, the update to asm:9.8 was also needed. Only with both forced dependencies I was able to compile with 24. asm-commons:9.8 isn't needed, but it'd probably be a bad idea to have a mismatch there.

yes both are needed. asm in the plugin itself is already done via #744
but this one we cannot really upgrade except making the plugin jdk11 required.
Personnally I would not mind but this might generate some discussions