[MSHARED-1041] Refactor: remove duplicate code, use addArg internally

[jira-importer]

Slawomir Jaranowski opened MSHARED-1041 and commented

We can replace methods like:

public InvocationRequest setDebug( boolean debug )
{
      this.debug = debug;
      return this;
}

by

public InvocationRequest setDebug( boolean debug )
{
      if ( debug )
      {
        addArg( "-X" );
      }
      return this;
} 

and simplify MavenCommandLineBuilder

---

Issue Links:

• MSHARED-1019 Allow pass raw cli option to Maven process

[jira-importer]

Michael Osipov commented

Fantastic, you read my mind. Though consider that your sample code is wrong. You need to check the arg for true.

[jira-importer]

Michael Osipov commented

I would also rename to setVerbose like we did in the CLI now.

[jira-importer]

Michael Osipov commented

I also wonder whether a huge method for two chars are justified.